This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
eskimor
added
A0-please_review
drahnr
reviewed
Mar 4, 2021
| .with_chunk_index(self.request.index.0) | ||
| .with_relay_parent(&self.relay_parent) | ||
| .build(); | ||
| let mut span_log = _span.log(); |
Contributor
There was a problem hiding this comment.
As discussed, we want to stick to tags and the builder API for now.
drahnr
reviewed
Mar 4, 2021
drahnr
reviewed
Mar 4, 2021
drahnr
reviewed
Mar 4, 2021
Contributor
drahnr
left a comment
drahnr
left a comment
There was a problem hiding this comment.
A few nits about using int tags rather than logs, other than that looks good, we might want to have a few more child span to get a bit more detail for dot-jaeger.
Does fields(target = have side effects for the consumer of the tracing::Spans?
ordian
approved these changes
Mar 4, 2021
Co-authored-by: Andronik Ordian <write@reusable.software>
drahnr
reviewed
Mar 4, 2021
| } | ||
|
|
||
| /// Add an additional int tag to the span. | ||
| pub fn add_int_tag(&mut self, tag: &str, value: i64) { |
drahnr
approved these changes
Mar 4, 2021
Member
Author
|
bot merge |
|
Waiting for commit status. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Mar 9, 2021
* master: Make Substrate deps uniform (#2589) Mostly, let guide reflect #2579 (#2583) add accountkey20 conversion impls (#2576) Substrate companion #8275 (#2575) Make warning nicer (#2569) Print an error if a collator connects to a node without real-overseer (#2563) add log message when real-overseer is enabled (#2565) Jaeger spans for availability distribution (#2559) Fix links in docs. (#2556) bump spec versions in kusama, polkadot and westend again (#2557) Guide update for availability distribution. (#2554) Whole subsystem test for new availability-distribution (#2552) Companion for `ExecuteBlock` changes in Substrate (#2548) Initialize telemetry earlier (#2549)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2551