This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
maciejhirsz
added
A0-please_review
gnunicorn
approved these changes
Sep 21, 2020
Contributor
gnunicorn
left a comment
gnunicorn
left a comment
There was a problem hiding this comment.
But some version mixing I'd like to see explained.
Cargo.lock
Outdated
| "failure", | ||
| "futures 0.1.29", | ||
| "jsonrpc-core", | ||
| "jsonrpc-core 14.2.0", |
Contributor
There was a problem hiding this comment.
Why does this still contain 14.2.0 versions? We updated all jsonrpc to 15.0, right? By here some dependencies are specified as still bound to jsonrpc-core 14.2.0, is that intentional?
Contributor
Author
There was a problem hiding this comment.
Ah, I commited this after building with current substrate master, that's why it's there.
|
Waiting for commit status. |
|
Checks failed; merge aborted. |
gnunicorn
added
B1-releasenotes
and removed
B0-silent
Contributor
|
bot merge |
|
Trying merge. |
|
Merge failed: |
ordian
approved these changes
Sep 21, 2020
ordian
added a commit
that referenced
this pull request
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on paritytech/substrate#7157