This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
octol
added
A0-please_review
3 tasks
andresilva
suggested changes
Sep 15, 2020
rpc/src/lib.rs
Outdated
Comment on lines
102
to
103
| B: Send + Sync + 'static + sc_client_api::Backend<Block>, | ||
| <B as sc_client_api::Backend<Block>>::State: sp_state_machine::Backend<BlakeTwo256>, |
Contributor
There was a problem hiding this comment.
Suggested change
| B: Send + Sync + 'static + sc_client_api::Backend<Block>, | |
| <B as sc_client_api::Backend<Block>>::State: sp_state_machine::Backend<BlakeTwo256>, | |
| B: sc_client_api::Backend<Block> + Send + Sync + 'static, | |
| B::State: sp_state_machine::Backend<sp_runtime::traits::HashFor<Block>>, |
rpc/src/lib.rs
Outdated
| use sp_blockchain::{HeaderBackend, HeaderMetadata, Error as BlockChainError}; | ||
| use sp_consensus::SelectChain; | ||
| use sp_consensus_babe::BabeApi; | ||
| use sp_runtime::traits::BlakeTwo256; |
Contributor
There was a problem hiding this comment.
Suggested change
| use sp_runtime::traits::BlakeTwo256; |
rpc/Cargo.toml
Outdated
| sp-api = { git = "https://github.com/paritytech/substrate", branch = "master" } | ||
| sp-consensus = { git = "https://github.com/paritytech/substrate", branch = "master" } | ||
| sp-consensus-babe = { git = "https://github.com/paritytech/substrate", branch = "master" } | ||
| sp-state-machine = { git = "https://github.com/paritytech/substrate", branch = "master"} |
Contributor
There was a problem hiding this comment.
I think it can be removed with the edits below.
andresilva
approved these changes
Sep 18, 2020
added 2 commits
September 18, 2020 16:39
|
Waiting for commit status. |
Contributor
|
Blocked by #1734. Should be good to go after that. |
|
Head SHA changed; merge aborted. |
Contributor
|
bot merge |
|
Waiting for commit status. |
|
Merge failed: |
bkchr
approved these changes
Sep 18, 2020
Member
|
(The pr also needs to update |
Member
Thank you @octol, I realized I was stupid. |
ordian
added a commit
that referenced
this pull request
Sep 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an on-demand API that clients can call to catch up on the stream of proofs if they need to fill in missing proofs. For example after a period of being offline.
companion PR for: paritytech/substrate#6215