Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

@jasl
Copy link
Contributor

@jasl jasl commented Aug 7, 2020

This is not a big problem.

You can find "✍️ Starting parachain attestation" isn't alignment with other output

image

I do a little experiment, I copy this string to terminal and I found the space between ✍️ and Starting disappeared, so give one more space would help for alignment

@cla-bot-2020
Copy link

cla-bot-2020 bot commented Aug 7, 2020

@jasl it looks like you have not signed our contributor license aggreement yet. Please visit this link to sign our agreement. This pull request cannot be merged until the agrement is signed.

@cla-bot-2020
Copy link

cla-bot-2020 bot commented Aug 7, 2020

@jasl, Your signature has been received.

@bkchr bkchr added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 7, 2020
@bkchr
Copy link
Member

bkchr commented Aug 7, 2020

bot merge

@ghost
Copy link

ghost commented Aug 7, 2020

Waiting for commit status.

@ghost ghost merged commit e8d5146 into paritytech:master Aug 7, 2020
@jasl jasl deleted the patch-1 branch August 7, 2020 15:22
ordian added a commit that referenced this pull request Aug 9, 2020
* master:
  Implementer's guide: Messaging overview stub (#1405)
  Align for "Starting parachain attestation session" (#1554)
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants