Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Companion PR to delaying network startup to after initialization#1547

Merged
gavofyork merged 1 commit intomasterfrom
tka-companion-nethack
Aug 6, 2020
Merged

Companion PR to delaying network startup to after initialization#1547
gavofyork merged 1 commit intomasterfrom
tka-companion-nethack

Conversation

@tomaka
Copy link
Contributor

@tomaka tomaka commented Aug 6, 2020 •
edited
Loading

@tomaka tomaka added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. C1-low PR touches the given topic and has a low impact on builders. labels Aug 6, 2020
@tomaka tomaka requested review from bkchr and expenses August 6, 2020 11:48
@tomaka tomaka mentioned this pull request Aug 6, 2020
Merged
@gavofyork gavofyork merged commit 3487a93 into master Aug 6, 2020
@gavofyork gavofyork deleted the tka-companion-nethack branch August 6, 2020 12:30
@ghost
Copy link

ghost commented Aug 6, 2020

Failed updating substrate.

@expenses expenses mentioned this pull request Aug 6, 2020
Merged
ordian added a commit that referenced this pull request Aug 6, 2020
@ordian
Merge branch 'master' into ao-prometheus-metrics
bdc89ca 
* master:
  Companion PR to delaying network startup to after initialization (#1547)
  Add SyncOracle to network's Service (#1543)
  Ignore checks for companion PRs (#1455)
  Add an Origin to parachains v1 (#1542)
bkchr pushed a commit that referenced this pull request Aug 6, 2020
@tomaka @bkchr
Companion PR to delaying network startup to after initialization (#1547)
96a6ee8
bkchr pushed a commit that referenced this pull request Aug 6, 2020
@tomaka @bkchr
Companion PR to delaying network startup to after initialization (#1547)
bb02af4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@expenses expenses Awaiting requested review from expenses

1 more reviewer

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. A4-companion A PR that needs a companion PR to merge in parallel for one of its downstream dependencies. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomaka @bkchr @gavofyork