Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Add SyncOracle to network's Service#1543

Merged
bkchr merged 7 commits intomasterfrom
cecton-add-sync-oracle
Aug 6, 2020
Merged

Add SyncOracle to network's Service#1543
bkchr merged 7 commits intomasterfrom
cecton-add-sync-oracle

Conversation

@cecton
Copy link
Contributor

@cecton cecton commented Aug 5, 2020 •
edited
Loading

cecton added 3 commits August 5, 2020 16:55
@cecton
WIP
d3d1219
@cecton
WIP
b7c7625 
Forked at: e916423
Parent branch: origin/rococo-branch
@cecton
WIP
6df903d 
Forked at: e916423
Parent branch: origin/rococo-branch
@github-actions github-actions bot added the A3-in_progress Pull request is in progress. No review needed at this stage. label Aug 5, 2020
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
cecton
cecton commented Aug 5, 2020
View reviewed changes
@cecton cecton requested a review from bkchr August 5, 2020 15:02
@cecton cecton marked this pull request as ready for review August 5, 2020 15:02
@github-actions github-actions bot added A0-please_review Pull request needs code review. and removed A3-in_progress Pull request is in progress. No review needed at this stage. labels Aug 5, 2020
@cecton cecton added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Aug 5, 2020
cecton
cecton commented Aug 5, 2020
View reviewed changes
@cecton cecton requested a review from rphmeier August 6, 2020 04:11
@bkchr bkchr merged commit 9c04ebb into master Aug 6, 2020
@bkchr bkchr deleted the cecton-add-sync-oracle branch August 6, 2020 08:15
cecton added a commit that referenced this pull request Aug 6, 2020
@cecton
Add SyncOracle to network's Service (#1543)
bb44855 
* WIP

* WIP

Forked at: e916423
Parent branch: origin/rococo-branch

* WIP

Forked at: e916423
Parent branch: origin/rococo-branch

* Apply suggestions from code review

* Update collator/src/lib.rs

* Update collator/src/lib.rs

* Update network/src/protocol/mod.rs
ordian added a commit that referenced this pull request Aug 6, 2020
@ordian
Merge branch 'master' into ao-prometheus-metrics
bdc89ca 
* master:
  Companion PR to delaying network startup to after initialization (#1547)
  Add SyncOracle to network's Service (#1543)
  Ignore checks for companion PRs (#1455)
  Add an Origin to parachains v1 (#1542)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rphmeier rphmeier Awaiting requested review from rphmeier

1 more reviewer

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cecton @bkchr