This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Sudo wrapper for paras#1517
Merged
rphmeier merged 3 commits intoparitytech:masterfrom Aug 3, 2020
montekki:fs-parachains-runtime-sudo-wrapper
Merged
Sudo wrapper for paras#1517rphmeier merged 3 commits intoparitytech:masterfrom montekki:fs-parachains-runtime-sudo-wrapper
rphmeier merged 3 commits intoparitytech:masterfrom
montekki:fs-parachains-runtime-sudo-wrapper
Conversation
montekki
added
A0-please_review
rphmeier
reviewed
Aug 1, 2020
runtime/parachains/src/paras.rs
Outdated
|
|
||
| /// Schedule a para to be initialized at the start of the next session. | ||
| #[weight = (1_000, DispatchClass::Operational)] | ||
| pub fn sudo_schedule_para_initialize( |
Contributor
There was a problem hiding this comment.
I would prefer this be in a separate module, because this is a low-level module that we shouldn't need to expose directly
Contributor
There was a problem hiding this comment.
It should be in the common crate or a separate crate, though, not the parachains crate. my rationale is that the parachains-core layer should be agnostic as to how and when paras get registered, only that they do.
ordian
added a commit
that referenced
this pull request
Aug 5, 2020
* master: Unalias Substrate Imports (#1530) Rewrite client handling (#1531) Integrate ChainApi with all messages (#1533) Add Rococo test network (#1363) Fix a typo parathreads -> parachains (#1529) Cleanup upcoming paras (#1527) Sudo wrapper for paras (#1517) Implementer's guide: notes on contextual execution (#1525) Companion for substrate/6782 (#1523) Sort out validation errors (#1516)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sudo wrapper for paras was forgotten. Should constant weights be here and return values from the functions be ignored? If not how do we go from
WeighttoDispatchResult?