This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
bkchr
added
A0-please_review
gavofyork
reviewed
Jul 12, 2020
runtime/rococo/src/lib.rs
Outdated
| pub MinSolutionScoreBump: Perbill = Perbill::from_rational_approximation(5u32, 10_000); | ||
| } | ||
|
|
||
| impl staking::Trait for Runtime { |
Member
There was a problem hiding this comment.
any need for staking? why not just a poa chain?
Member
Author
There was a problem hiding this comment.
Good point.
@cecton could you please remove the staking pallet and regenerate the chain specs?
Contributor
There was a problem hiding this comment.
To regenerate the chain specs I use build-spec --chain=rococo and I remove the entries in bootbodes in the JSON?
Contributor
There was a problem hiding this comment.
Nevermind it's fine I think. Can you double check?
Contributor
|
We should merge if the reviewers are ok |
Contributor
This reverts commit a159f12.
Contributor
|
🤣 |
rphmeier
reviewed
Aug 3, 2020
rphmeier
reviewed
Aug 3, 2020
Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
Co-authored-by: Robert Habermeier <rphmeier@gmail.com>
rphmeier
approved these changes
Aug 3, 2020
Contributor
|
bot merge |
|
Trying merge. |
ghost
merged commit
ordian
added a commit
that referenced
this pull request
Aug 5, 2020
* master: Unalias Substrate Imports (#1530) Rewrite client handling (#1531) Integrate ChainApi with all messages (#1533) Add Rococo test network (#1363) Fix a typo parathreads -> parachains (#1529) Cleanup upcoming paras (#1527) Sudo wrapper for paras (#1517) Implementer's guide: notes on contextual execution (#1525) Companion for substrate/6782 (#1523) Sort out validation errors (#1516)
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.