-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Cumulus: pre-connect to backers before own slot #9929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
73 commits
Select commit
Hold shift + click to select a range
97555c7
collator-protocol: cleanup connecting to backing group
alexggh 2fc08e1
fixup connection to validators
alexggh 48ab6d0
fix tests and cleanup unneeded code
alexggh f6b47ba
Merge remote-tracking branch 'origin/master' into cleanup_connecting_…
alexggh ac823cc
Merge branch 'master' of github.com:paritytech/polkadot-sdk into alex…
sandreim 76d7cdf
ensure we consider all valid relay parents
sandreim 1ac73b5
Update from github-actions[bot] running command 'prdoc generate --bum…
github-actions[bot] 39fb8e1
Support ConnectToBackingGroups
sandreim 47923b6
fix origin
sandreim 0ede4bb
add disconnect mechanism
sandreim eb51a3e
move collator_protocol_helper
sandreim 17d1c6c
comment
sandreim 06c444f
remove helper from service
sandreim 8fe9db5
unused
sandreim 3b63265
unused deps in crates
sandreim bda8c38
Update from github-actions[bot] running command 'prdoc generate --bum…
github-actions[bot] 9cfd857
fix tests
sandreim e954ea4
Merge branch 'sandreim/collator_protocol_notifications' of github.com…
sandreim c2dce30
Update from github-actions[bot] running command 'fmt'
github-actions[bot] 2d78334
fmt
sandreim 6bec872
add offset
sandreim 3deacd3
Merge branch 'sandreim/collator_protocol_notifications' of github.com…
sandreim b977e32
fmt
sandreim f0a76d5
prdoc
sandreim 0dbdd9c
move log
sandreim 699b00a
impl disconnect
sandreim 597a50c
fix some stuff
sandreim bf35a8e
add some tests for connect/disconnect
sandreim 334fd92
fix cargo toml
sandreim 9b7b37f
fix prdoc
sandreim 7112e9f
fix prdoc
sandreim af9421f
Merge branch 'alexggh/cleanup_connecting_to_backing_group' of github.…
sandreim 89fb028
review feedback
sandreim cae1c25
fix comment
sandreim 471b898
fix test comments
sandreim b4e6db2
review
sandreim 85c0597
fix validator disconnect
sandreim dbcd11a
make Basti happy
sandreim d3afbeb
fix comments
sandreim d4b17d9
fix cumulus-test-service
sandreim 920a015
fix node tenplate
sandreim ff8f2c7
Update polkadot/node/network/collator-protocol/Cargo.toml
sandreim 339e80e
to much spawning
sandreim fb0e463
review
sandreim 3d51b37
Merge branch 'sandreim/collator_protocol_notifications' of github.com…
sandreim eca9049
Merge branch 'master' of github.com:paritytech/polkadot-sdk into alex…
sandreim 9e4578b
Merge branch 'alexggh/cleanup_connecting_to_backing_group' of github.…
sandreim 5261e54
test comment
sandreim f106131
remove validator buffer file
sandreim 46c141e
Merge branch 'alexggh/cleanup_connecting_to_backing_group' into sandr…
sandreim 05a4989
Update cumulus/client/consensus/aura/src/collators/mod.rs
sandreim 762e1d5
Update polkadot/node/network/collator-protocol/src/collator_side/mod.rs
sandreim c661973
review
sandreim c07e117
Update cumulus/client/consensus/aura/src/collators/mod.rs
sandreim 978f657
Merge branch 'alexggh/cleanup_connecting_to_backing_group' of github.…
sandreim 7435522
review feedback
sandreim efa7ae7
update CI test
sandreim 43285d6
fix ident
sandreim 64e0065
;
sandreim 386ca15
fix tests
sandreim ce208e8
Merge branch 'master' of github.com:paritytech/polkadot-sdk into alex…
sandreim 02362a9
remove clone derive
sandreim 0169bd6
update prdoc
sandreim 1296305
Merge branch 'alexggh/cleanup_connecting_to_backing_group' into sandr…
sandreim afaee88
accurate comments
sandreim 6e40e55
Merge branch 'master' of github.com:paritytech/polkadot-sdk into sand…
sandreim 0f800b7
comment
sandreim a9c986a
Update from github-actions[bot] running command 'fmt'
github-actions[bot] 15728d8
unused dep
sandreim 340739b
Merge branch 'sandreim/collator_protocol_notifications' of github.com…
sandreim 82a0658
simplify and more coverage in tests
sandreim cce0b12
change string
sandreim 9093bab
even simpler
sandreim File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But this means that even the author of the current slot will call the function below. Because
can_build_uponcan claim a slot, but the runtime says no.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but the call should not have any effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty sure we can avoid this, but as far as I can see is a good tradeoff to keep things simple. Or maybe you can suggest a simple way to avoid it ?