Cumulus: pre-connect to backers before own slot#9929
Merged
Conversation
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io>
…ggh/cleanup_connecting_to_backing_group Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
bkchr
reviewed
Oct 3, 2025
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Contributor
Author
|
/cmd prdoc generate --bump major |
sandreim
added
T0-node
…:paritytech/polkadot-sdk into sandreim/collator_protocol_notifications
Contributor
Author
|
/cmd fmt |
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…:paritytech/polkadot-sdk into sandreim/collator_protocol_notifications
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…eim/collator_protocol_notifications
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Base automatically changed from
alexggh/cleanup_connecting_to_backing_group
to
master
October 20, 2025 12:54
…reim/collator_protocol_notifications
Contributor
Author
|
/cmd fmt |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
…:paritytech/polkadot-sdk into sandreim/collator_protocol_notifications
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>
skunert
approved these changes
Oct 30, 2025
| .map(|h| BackingGroupConnectionHelper::new(para_client.clone(), keystore.clone(), h.clone())) | ||
| .or_else(|| { | ||
| tracing::warn!(target: LOG_TARGET, | ||
| "Relay chain interface does not provide overseer handle. Backing group pre-connect is disabled."); |
Contributor
There was a problem hiding this comment.
This could be an abort condition, I don't think we can handle this gracefully. How would we submit the collation and everything. Should never happen.
bkchr
approved these changes
Nov 3, 2025
github-project-automation
bot
moved this from Review/Audit in progress
to Completed
in parachains team board
RomarQ
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Dec 3, 2025
On top of paritytech#9178. Implements a mechanism to pre-connect to backers, see paritytech#9767 (comment) How it works: - connect to backers 6s before own slot starts - disconnect from all backers and stop connecting as the RC advances if own slot has finished TODO: - [x] fix collator protocol tests - [x] Explicitly disconnect from all backers when own slot has passed - [x] add test coverage for new connect/disconnect notifications --------- Signed-off-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io> Signed-off-by: Andrei Sandu <andrei-mihail@parity.io> Co-authored-by: Alexandru Gheorghe <alexandru.gheorghe@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Alexandru Gheorghe <49718502+alexggh@users.noreply.github.com> Co-authored-by: Bastian Köcher <git@kchr.de>
github-project-automation
bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #9178. Implements a mechanism to pre-connect to backers, see #9767 (comment)
How it works:
TODO: