Skip to content

Conversation

@paritytech-release-backport-bot

Backport #9094 into stable2506 from alexggh.

See the documentation on how to use this bot.

…#9094)

`handle_peer_view_change` gets called on NewGossipTopology with the
existing view of the peer to cover for the case when the topology might
arrive late, but in that case in the view will contain old blocks from
previous session, so since the X/Y neighbour change because of the
topology change you end up sending a lot of messages for blocks before
the session changed.

Fix it by checking the send message only for relay chains that are in
the same session as the current topology.

---------

Signed-off-by: Alexandru Gheorghe <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 12ddb5a)
@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Jul 10, 2025
@github-actions github-actions bot requested a review from alexggh July 10, 2025 10:36
@github-actions
Copy link
Contributor

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@alexggh alexggh enabled auto-merge (squash) July 10, 2025 10:50
@alexggh alexggh merged commit c3bfa7a into stable2506 Jul 10, 2025
244 of 245 checks passed
@alexggh alexggh deleted the backport-9094-to-stable2506 branch July 10, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants