Conversation
…didateIncluded` events in polkadot/zombienet_tests/functional/0019-coretime-collation-fetching-fairness.zndsl
tdimitrov
added
R0-no-crate-publish-required
alexggh
approved these changes
Jun 20, 2025
sandreim
approved these changes
Jun 20, 2025
alindima
reviewed
Jun 20, 2025
alindima
reviewed
Jun 20, 2025
alindima
approved these changes
Jun 20, 2025
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
…-coretime-collation-fetching-fairness.zndsl (#8921) `polkadot/zombienet_tests/functional/0019-coretime-collation-fetching-fairness.zndsl` is flaky on CI. I suspect the reason for this is session changes happening during the measurement step. To make this more predictable I've modified the checker to wait for a session change before counting the `CandidateIncluded` events. Hopefully this will stabilize the test on CI too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
polkadot/zombienet_tests/functional/0019-coretime-collation-fetching-fairness.zndslis flaky on CI. I suspect the reason for this is session changes happening during the measurement step. To make this more predictable I've modified the checker to wait for a session change before counting theCandidateIncludedevents. Hopefully this will stabilize the test on CI too.