Merged
Conversation
alvicsam
requested changes
Jun 24, 2025
Contributor
alvicsam
left a comment
alvicsam
left a comment
There was a problem hiding this comment.
Amazing job!
I have only a few comments related to inputs of a reusable github action.
Contributor
Author
|
Test results from nightly test 2025-06-24
|
alvicsam
approved these changes
Jun 25, 2025
pepoviola
requested review from
alindima,
eskimor,
michalkucharczyk,
sandreim,
serban300 and
skunert
alindima
reviewed
Jun 26, 2025
alindima
reviewed
Jun 26, 2025
Contributor
alindima
left a comment
alindima
left a comment
There was a problem hiding this comment.
Only some nits remaining from me
| # We need to use an older version of polkadot/polkadot-parachain, particulary a version that doesn't includes | ||
| # https://github.com/paritytech/polkadot-sdk/pull/1644, and since this change is also used by the collators we need to | ||
| # keep this test to ensure that works with older versions. | ||
| - name: download_old_release_bins |
Contributor
There was a problem hiding this comment.
could we maybe abstract this into some script? I'm pretty sure other tests will need it too (and it's already duplicated for 2 tests)
Contributor
There was a problem hiding this comment.
We could do this later if you want, I really want us to start running zombienet tests again
Contributor
There was a problem hiding this comment.
Yes, is alredy used twice. I will move the logic to a reusable action. Thx!!
polkadot/zombienet_tests/functional/0014-chunk-fetching-network-compatibility.toml
Outdated
Show resolved
Hide resolved
alindima
approved these changes
Jun 26, 2025
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
alvicsam
pushed a commit
that referenced
this pull request
Oct 17, 2025
This PR re-enables Zombienet CI tests.
Changes:
- Enable Zombienet Polkadot and Substrate tests
- Zombienet Cumulus will be enabled separately, when being migrated to
`zombienet-sdk`
- Switch zombienet from `k8s` to `native` provider
`k8s` turned out to be unstable for both `zombienet` and
`zombienet-sdk`. Issues observed:
- problem with launching a pod
- pods (and thus nodes) were not spawned at the same time (differences
up to 120s), which affected some tests
- `kubectl` command failed
Observed many times for:
- kubectl cp
- kubectl exec
- kubectl logs
If we ever want to switch back to `k8s` we must ensure above issues no
longer exist.
- Tweaks some tests to make sure they constantly pass
Authors of those tests are kindly asked to review the changes.
- Some improvements and fixes `zombienet` and `zombienet-sdk` frameworks
- Assign more beefy runners for more demanding tests
Rule of thumb: use large runner if spawned network consist of more than
4 nodes
- Disable some tests to let their authors to stabilize them
Created a dedicated `.github/zombienet-flaky-tests` file for more
clarity
ATM there are 16 flaky tests. Their authors are kindly asked to fix them
and re-enable.
---------
Co-authored-by: Javier Viola <javier@parity.io>
Co-authored-by: Javier Viola <363911+pepoviola@users.noreply.github.com>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anthony Lazam <xlzm.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR re-enables Zombienet CI tests.
Changes:
zombienet-sdkk8stonativeproviderk8sturned out to be unstable for bothzombienetandzombienet-sdk. Issues observed:kubectlcommand failedObserved many times for:
If we ever want to switch back to
k8swe must ensure above issues no longer exist.Authors of those tests are kindly asked to review the changes.
zombienetandzombienet-sdkframeworksRule of thumb: use large runner if spawned network consist of more than 4 nodes
Created a dedicated
.github/zombienet-flaky-testsfile for more clarityATM there are 16 flaky tests. Their authors are kindly asked to fix them and re-enable.