Snowbridge V2: Check that the reward address matches the relayer#8184
Closed
yrong wants to merge 2 commits intoparitytech:masterfrom
Closed
Snowbridge V2: Check that the reward address matches the relayer#8184yrong wants to merge 2 commits intoparitytech:masterfrom
yrong wants to merge 2 commits intoparitytech:masterfrom
Conversation
acatangiu
added
T15-bridges
dimartiro
approved these changes
Apr 8, 2025
Contributor
dimartiro
left a comment
dimartiro
left a comment
There was a problem hiding this comment.
Thanks for addressing the issue!
Contributor
claravanstaden
left a comment
claravanstaden
left a comment
There was a problem hiding this comment.
@yrong I think this fix is better than my fix: claravanstaden#11 :) Could you perhaps open this PR into https://github.com/claravanstaden/polkadot-sdk/tree/snowbridge-v2-audit-fixes? I'm merging all the security fixes in there to open 1 PR to the polkadot-sdk (to make backporting easier).
Contributor
Author
|
Closed in favor of claravanstaden#20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #8154