Audit Issue 5: Use reward address (if set) for reward allocation in the Outbound Queue v2#20
Merged
claravanstaden merged 4 commits intoclaravanstaden:snowbridge-v2-audit-fixesfrom Apr 17, 2025
Conversation
yrong
changed the title
acatangiu
approved these changes
Apr 10, 2025
vgeddes
reviewed
Apr 11, 2025
|
Review required! Latest push from author must always be reviewed |
vgeddes
reviewed
Apr 16, 2025
| // Verify that the message was submitted from the known Gateway contract | ||
| ensure!(T::GatewayAddress::get() == receipt.gateway, Error::<T>::InvalidGateway); | ||
|
|
||
| let reward_account: T::AccountId = receipt.reward_address.into(); |
There was a problem hiding this comment.
As a fallback, if receipt.reward_address is zero bytes, we should rather reward the relayer.
claravanstaden
approved these changes
Apr 17, 2025
vgeddes
approved these changes
Apr 17, 2025
claravanstaden
merged commit 8f9d985
into
claravanstaden:snowbridge-v2-audit-fixes
95 of 189 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.