Update transfer token gas and fee

[alistair-singh]

Update the gas allowance of the TransferToken related commands. This also means that the default fee needs to be increased as well as a migration.

Migration

In production mainnet to ensure no downtime, instead of increasing the fee to account for the new gas fee, we will instead decrease the gas cost so that it will not require a fee increase.

The pre remote fee in Wei:

(185_000 + 100_000) * 10_000_000_000 + 250_000_000_000_000
> 3100000000000000

We are increasing the gas to 200k.

The post remote fee Wei:

(185_000 + 200_000) * 10_000_000_000 + 250_000_000_000_000
> 4100000000000000

This effectively increases the price for the end users transaction by 32%. Taking the inverse of 32 percent means we can decrease the gas cost by ~74%. The migration script plays it safe and decreases it to 70%. The post migration try-runtime check asserts that the new fee calculated with the increased gas can is less than or equal to the old fee pre the gas change.

TODO

• Add migration to half fee on bridge on start-up
• Test in prod with chopsticks

Testing

Tested with chopsticks on westend.

$ npx @acala-network/chopsticks try-runtime \
  --endpoint wss://westend-bridge-hub-rpc-tn.dwellir.com \
  --runtime bridge_hub_westend_runtime.compact.wasm \
  --checks PreAndPost \
  --db westend-cache.sqllite \
  --disable-spec-check

Output

$ cat output.log | grep ethereum_system
  ethereum_system::migration   INFO: Agents and channels are initialized. Initialization will not run.
  ethereum_system::migration   INFO: Ethereum system already initialized. Skipping.
  ethereum_system::migration   INFO: Pre fee per gas migration: pricing parameters = PricingParameters { exchange_rate: , rewards: Rewards { local: 1000000000000, remote: 1000000000000000 }, fee_per_gas: 20000000000, multiplier:  }, remote_fee_v1 = 8700000000000000, remote_fee_v2 = 5000000000000000
  ethereum_system::migration   INFO: Fee per gas migrated from 20000000000 to 14000000000.
  ethereum_system::migration   INFO: Post fee per gas migration: pricing parameters = PricingParameters { exchange_rate: , rewards: Rewards { local: 1000000000000, remote: 1000000000000000 }, fee_per_gas: 14000000000, multiplier:  } remote_fee_v1 = 6390000000000000 remote_fee_v2 = 3800000000000000

[claravanstaden]

Could probably add the value here and then reuse: https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/parachains/runtimes/constants/src/westend.rs#L172 Not a major issue though

[acatangiu]

@alistair-singh when/where would you want to deploy this? do we backport to 2503 and it comes with snowbridge v2? or do you want it earlier so we also backport to 2412?

[alistair-singh]

@alistair-singh when/where would you want to deploy this? do we backport to 2503 and it comes with snowbridge v2? or do you want it earlier so we also backport to 2412?

Backport to 2412 please. I want to get it out asap. Its blocking some token transfer cases for Hydration.

[paritytech-release-backport-bot]

Created backport PR for stable2412:

• [stable2412] Backport #7947 #8258 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7947-to-stable2412
git worktree add --checkout .worktree/backport-7947-to-stable2412 backport-7947-to-stable2412
cd .worktree/backport-7947-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 13cb4a31f77a14ea1bec880a7369a59432afaec9
git push --force-with-lease

[paritytech-release-backport-bot]

Created backport PR for stable2503:

• [stable2503] Backport #7947 #8259 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-7947-to-stable2503
git worktree add --checkout .worktree/backport-7947-to-stable2503 backport-7947-to-stable2503
cd .worktree/backport-7947-to-stable2503
git reset --hard HEAD^
git cherry-pick -x 13cb4a31f77a14ea1bec880a7369a59432afaec9
git push --force-with-lease