Skip to content

Conversation

@ggwpez
Copy link
Member

@ggwpez ggwpez commented Mar 3, 2025

Changes:

  • Add runtime integrity test for scheduler pallet to ensure that lookups use sensible weights
  • Check all passed storage names in the omni bencher to be known by FRAME metadata
  • Trim storage names in omni bencher to fix V1 bench syntax bug
  • Fix V1 bench syntax storage name sanitization for specific Rust versions

I re-ran the benchmarks with the omni-bencher modifications and it did not change the proof size. I reverted the commit afterwards to reduce the noise for reviewers.

@ggwpez ggwpez requested a review from a team as a code owner March 3, 2025 19:11
@ggwpez ggwpez marked this pull request as draft March 3, 2025 19:12
@ggwpez
Copy link
Member Author

ggwpez commented Mar 4, 2025

/cmd bench --runtime westend asset-hub-westend

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2025

Command "bench --runtime westend asset-hub-westend" has started 🚀 See logs here

fellowship-merge-bot bot pushed a commit to polkadot-fellows/runtimes that referenced this pull request Mar 4, 2025
- **Add test to collectives pallet**
- **Manually edit scheduler weight**

## Investigation

The Rust compiler changed how the `stringify!` macro formats paths on
[Aug 12th
'24](rust-lang/rust#128992 (comment)).
I assume that this broke the V1 benchmarking
[here](https://github.com/paritytech/polkadot-sdk/blob/7ecf3f757a5d6f622309cea7f788e8a547a5dce8/substrate/frame/benchmarking/src/v1.rs#L1011).
We had updated the scheduler pallet to V2 syntax (which is [not
affected](https://github.com/paritytech/polkadot-sdk/blob/df99fb9431a579589c1c87832222c9551b5c4f7c/substrate/frame/support/procedural/src/benchmark.rs#L565))
on [Nov 20th '24](paritytech/polkadot-sdk#6292).
We did not back-port this since there was no apparent reason for it.
The is why it seemingly fixed it self on SDK master but not in the
runtimes repo (since that is using V1 scheduler benchmarking).
Another indication for this is the fact that it did work on the
[whitelist
pallet](https://github.com/polkadot-fellows/runtimes/blob/6b85bf6adb427942976648e6d235e0169dfced16/relay/polkadot/src/weights/pallet_whitelist.rs#L85),
which is on V2 much longer but used the same [custom pov
mode](https://github.com/paritytech/polkadot-sdk/blob/b76e91acc953e682b3ddcfc45ecacaaf26c694a1/substrate/frame/whitelist/src/benchmarking.rs#L68).

Adding some sanity checks to prevent this in the future here
paritytech/polkadot-sdk#7785

- [ ] Does not require a CHANGELOG entry

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
@github-actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Command "bench --runtime westend asset-hub-westend" has finished ✅ See logs here

Subweight results:
File Extrinsic Old New Change [%]
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/cumulus_pallet_weight_reclaim.rs storage_weight_reclaim 3.98us 9.21us +131.51
polkadot/runtime/westend/src/weights/pallet_utility.rs if_else 9.34us 12.05us +29.02
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/frame_system.rs remark 43.58ms 55.31ms +26.93
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/frame_system.rs remark_with_event 49.71ms 60.65ms +22.01
polkadot/runtime/westend/src/weights/pallet_beefy_mmr.rs n_leafs_proof_is_optimal 1.87us 2.09us +11.71
polkadot/runtime/westend/src/weights/frame_system_extensions.rs check_non_zero_sender 594.00ns 643.00ns +8.25
polkadot/runtime/westend/src/weights/polkadot_runtime_parachains_initializer.rs force_approve 53.82us 57.93us +7.64
polkadot/runtime/westend/src/weights/frame_system_extensions.rs check_spec_version 446.00ns 478.00ns +7.17
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_timestamp.rs on_finalize 4.66us 4.94us +5.94
polkadot/runtime/westend/src/weights/frame_system_extensions.rs check_tx_version 468.00ns 495.00ns +5.77
polkadot/runtime/westend/src/weights/pallet_staking.rs force_no_eras 108.37us 114.52us +5.67
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/xcm/pallet_xcm_benchmarks_fungible.rs receive_teleported_asset 3.09us 3.26us +5.51
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_transact_status 884.00ns 931.00ns +5.32
polkadot/runtime/westend/src/weights/pallet_staking.rs force_new_era_always 108.33us 113.85us +5.10
polkadot/runtime/westend/src/weights/pallet_staking.rs force_new_era 108.31us 113.80us +5.07
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs refund_surplus 1.48us 1.40us -5.08
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs asset_claimer 827.00ns 785.00ns -5.08
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_error 774.00ns 731.00ns -5.56
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_pallet 5.66us 5.33us -5.99
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_migrations.rs on_init_loop 229.00ns 213.00ns -6.99
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_transact_status 853.00ns 793.00ns -7.03
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_error_handler 827.00ns 768.00ns -7.13
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs burn_asset 1.25us 1.15us -8.21
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs unpaid_execution 812.00ns 744.00ns -8.37
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_error 783.00ns 716.00ns -8.56
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_topic 759.00ns 693.00ns -8.70
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs execute_with_origin 907.00ns 826.00ns -8.93
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs descend_origin 834.00ns 756.00ns -9.35
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_origin 815.00ns 738.00ns -9.45
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_transact_status 973.00ns 875.00ns -10.07
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs clear_origin 808.00ns 726.00ns -10.15
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_appendix 817.00ns 733.00ns -10.28
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_topic 782.00ns 701.00ns -10.36
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs set_fees_mode 793.00ns 706.00ns -10.97
polkadot/runtime/westend/src/weights/pallet_staking.rs do_elect_paged_inner 238.63ns 209.26ns -12.31
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs expect_asset 911.00ns 795.00ns -12.73
cumulus/parachains/runtimes/assets/asset-hub-westend/src/weights/pallet_multisig.rs as_multi_threshold_1 24.27us 21.13us -12.96
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs trap 825.00ns 718.00ns -12.97
polkadot/runtime/westend/src/weights/xcm/pallet_xcm_benchmarks_generic.rs buy_execution 843.00ns 723.00ns -14.23
polkadot/runtime/westend/src/weights/pallet_multisig.rs as_multi_threshold_1 26.53us 21.14us -20.32
Command output:

✅ Successful benchmarks of runtimes/pallets:
-- westend: ['pallet_xcm_benchmarks::fungible', 'polkadot_runtime_parachains::coretime', 'pallet_message_queue', 'polkadot_runtime_common::auctions', 'pallet_utility', 'frame_system', 'pallet_staking', 'pallet_identity', 'pallet_transaction_payment', 'polkadot_runtime_common::assigned_slots', 'pallet_treasury', 'pallet_offences', 'pallet_whitelist', 'pallet_sudo', 'polkadot_runtime_parachains::paras_inherent', 'pallet_bags_list', 'pallet_scheduler', 'polkadot_runtime_parachains::disputes', 'polkadot_runtime_parachains::disputes::slashing', 'polkadot_runtime_parachains::inclusion', 'pallet_mmr', 'polkadot_runtime_parachains::hrmp', 'frame_election_provider_support', 'polkadot_runtime_common::paras_registrar', 'pallet_beefy_mmr', 'pallet_parameters', 'polkadot_runtime_common::crowdloan', 'pallet_xcm', 'pallet_recovery', 'pallet_preimage', 'pallet_asset_rate', 'pallet_conviction_voting', 'pallet_nomination_pools', 'pallet_multisig', 'polkadot_runtime_common::slots', 'polkadot_runtime_parachains::paras', 'pallet_referenda', 'frame_system_extensions', 'pallet_migrations', 'polkadot_runtime_parachains::initializer', 'polkadot_runtime_parachains::configuration', 'polkadot_runtime_common::identity_migrator', 'pallet_fast_unstake', 'pallet_timestamp', 'polkadot_runtime_parachains::on_demand', 'pallet_balances', 'pallet_session', 'pallet_election_provider_multi_phase', 'pallet_vesting', 'pallet_indices', 'pallet_xcm_benchmarks::generic', 'pallet_proxy']
-- asset-hub-westend: ['pallet_assets', 'pallet_xcm_benchmarks::fungible', 'pallet_collator_selection', 'cumulus_pallet_parachain_system', 'pallet_uniques', 'pallet_message_queue', 'pallet_utility', 'frame_system', 'pallet_asset_rewards', 'pallet_nft_fractionalization', 'cumulus_pallet_weight_reclaim', 'pallet_asset_conversion_tx_payment', 'pallet_transaction_payment', 'pallet_xcm_bridge_hub_router', 'pallet_asset_conversion_ops', 'pallet_xcm', 'pallet_multisig', 'frame_system_extensions', 'pallet_migrations', 'pallet_asset_conversion', 'pallet_nfts', 'pallet_timestamp', 'pallet_balances', 'pallet_session', 'cumulus_pallet_xcmp_queue', 'pallet_xcm_benchmarks::generic', 'pallet_proxy']

@ggwpez
Copy link
Member Author

ggwpez commented Mar 5, 2025

/cmd prdoc --bump minor --audience runtime_dev

@ggwpez ggwpez marked this pull request as ready for review March 6, 2025 11:07
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick, otherwise looks good.

@RomarQ
Copy link
Contributor

RomarQ commented May 14, 2025

This is still a problem. Moonbeam is using the latest changes from branch stable2412 and the issue is not solved.

image

moonbeam-foundation/moonbeam#3286

@RomarQ
Copy link
Contributor

RomarQ commented May 14, 2025

We should port the benchmark v2 migration to the stable2412 branch at least, otherwise this will for sure impact other projects

@ggwpez ggwpez added T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights. labels May 14, 2025
Signed-off-by: Oliver Tale-Yazdi <[email protected]>
paritytech-release-backport-bot bot pushed a commit that referenced this pull request May 23, 2025
Changes:
- Add runtime integrity test for scheduler pallet to ensure that lookups
use sensible weights
- Check all passed storage names in the omni bencher to be known by
FRAME metadata
- Trim storage names in omni bencher to fix V1 bench syntax bug
- Fix V1 bench syntax storage name sanitization for specific Rust
versions

I re-ran the benchmarks with the omni-bencher modifications and it did
not change the [proof
size](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=1&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=cc0142510b81dcf1c1a22f7dc164c453c25287e6&new=bb19d78821eaeaf2262f6a23ee45f83dd4f94d29).
I reverted [the
commit](bb19d78)
afterwards to reduce the noise for reviewers.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 058b4f5)
@paritytech-release-backport-bot

Successfully created backport PR for stable2407:

paritytech-release-backport-bot bot pushed a commit that referenced this pull request May 23, 2025
Changes:
- Add runtime integrity test for scheduler pallet to ensure that lookups
use sensible weights
- Check all passed storage names in the omni bencher to be known by
FRAME metadata
- Trim storage names in omni bencher to fix V1 bench syntax bug
- Fix V1 bench syntax storage name sanitization for specific Rust
versions

I re-ran the benchmarks with the omni-bencher modifications and it did
not change the [proof
size](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=1&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=cc0142510b81dcf1c1a22f7dc164c453c25287e6&new=bb19d78821eaeaf2262f6a23ee45f83dd4f94d29).
I reverted [the
commit](bb19d78)
afterwards to reduce the noise for reviewers.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 058b4f5)
@paritytech-release-backport-bot

Successfully created backport PR for stable2409:

@paritytech-release-backport-bot

Git push to origin failed for stable2407 with exitcode 1

paritytech-release-backport-bot bot pushed a commit that referenced this pull request May 23, 2025
Changes:
- Add runtime integrity test for scheduler pallet to ensure that lookups
use sensible weights
- Check all passed storage names in the omni bencher to be known by
FRAME metadata
- Trim storage names in omni bencher to fix V1 bench syntax bug
- Fix V1 bench syntax storage name sanitization for specific Rust
versions

I re-ran the benchmarks with the omni-bencher modifications and it did
not change the [proof
size](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=1&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=cc0142510b81dcf1c1a22f7dc164c453c25287e6&new=bb19d78821eaeaf2262f6a23ee45f83dd4f94d29).
I reverted [the
commit](bb19d78)
afterwards to reduce the noise for reviewers.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 058b4f5)
@paritytech-release-backport-bot

Successfully created backport PR for stable2412:

@paritytech-release-backport-bot

Git push to origin failed for stable2409 with exitcode 1

paritytech-release-backport-bot bot pushed a commit that referenced this pull request May 23, 2025
Changes:
- Add runtime integrity test for scheduler pallet to ensure that lookups
use sensible weights
- Check all passed storage names in the omni bencher to be known by
FRAME metadata
- Trim storage names in omni bencher to fix V1 bench syntax bug
- Fix V1 bench syntax storage name sanitization for specific Rust
versions

I re-ran the benchmarks with the omni-bencher modifications and it did
not change the [proof
size](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=1&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=cc0142510b81dcf1c1a22f7dc164c453c25287e6&new=bb19d78821eaeaf2262f6a23ee45f83dd4f94d29).
I reverted [the
commit](bb19d78)
afterwards to reduce the noise for reviewers.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 058b4f5)
@paritytech-release-backport-bot

Successfully created backport PR for stable2503:

@paritytech-release-backport-bot

Git push to origin failed for stable2412 with exitcode 1

@paritytech-release-backport-bot

Git push to origin failed for stable2503 with exitcode 1

wilwade added a commit to frequency-chain/frequency that referenced this pull request May 23, 2025
wilwade added a commit to frequency-chain/frequency that referenced this pull request May 24, 2025
EgorPopelyaev added a commit that referenced this pull request May 27, 2025
Backport #7785 into `stable2503` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <[email protected]>
EgorPopelyaev pushed a commit that referenced this pull request May 27, 2025
Backport #7785 into `stable2407` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
EgorPopelyaev added a commit that referenced this pull request May 27, 2025
Backport #7785 into `stable2409` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <[email protected]>
dimartiro pushed a commit to moondance-labs/polkadot-sdk that referenced this pull request Jun 10, 2025
Backport paritytech#7785 into `stable2503` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <[email protected]>
ggwpez added a commit that referenced this pull request Jun 11, 2025
Update scheduler weights for
#8726

This was originally a backport of
#7785 but is now
re-purposed.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <[email protected]>
dimartiro pushed a commit to moondance-labs/polkadot-sdk that referenced this pull request Jun 24, 2025
Backport paritytech#7785 into `stable2503` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <[email protected]>
dimartiro pushed a commit to moondance-labs/polkadot-sdk that referenced this pull request Jul 2, 2025
Backport paritytech#7785 into `stable2503` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <[email protected]>
alstjd0921 pushed a commit to bifrost-platform/polkadot-sdk that referenced this pull request Aug 14, 2025
Backport paritytech#7785 into `stable2503` from ggwpez.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Egor_P <[email protected]>
alvicsam pushed a commit that referenced this pull request Oct 17, 2025
Changes:
- Add runtime integrity test for scheduler pallet to ensure that lookups
use sensible weights
- Check all passed storage names in the omni bencher to be known by
FRAME metadata
- Trim storage names in omni bencher to fix V1 bench syntax bug
- Fix V1 bench syntax storage name sanitization for specific Rust
versions

I re-ran the benchmarks with the omni-bencher modifications and it did
not change the [proof
size](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=1&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=cc0142510b81dcf1c1a22f7dc164c453c25287e6&new=bb19d78821eaeaf2262f6a23ee45f83dd4f94d29).
I reverted [the
commit](bb19d78)
afterwards to reduce the noise for reviewers.

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A4-backport-stable2503 Pull request must be backported to the stable2503 release branch T2-pallets This PR/Issue is related to a particular pallet. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants