Skip to content

Commit 939e986

Browse files
pallet scheduler: fix weight and add safety checks (#7785)
Changes: - Add runtime integrity test for scheduler pallet to ensure that lookups use sensible weights - Check all passed storage names in the omni bencher to be known by FRAME metadata - Trim storage names in omni bencher to fix V1 bench syntax bug - Fix V1 bench syntax storage name sanitization for specific Rust versions I re-ran the benchmarks with the omni-bencher modifications and it did not change the [proof size](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=1&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=cc0142510b81dcf1c1a22f7dc164c453c25287e6&new=bb19d78821eaeaf2262f6a23ee45f83dd4f94d29). I reverted [the commit](bb19d78) afterwards to reduce the noise for reviewers. --------- Signed-off-by: Oliver Tale-Yazdi <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 058b4f5)
1 parent aa89c59 commit 939e986

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

prdoc/pr_7785.prdoc

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
title: 'pallet scheduler: fix weight and add safety checks'
2+
doc:
3+
- audience: Runtime Dev
4+
description: |-
5+
Changes:
6+
- Add runtime integrity test for scheduler pallet to ensure that lookups use sensible weights
7+
- Check all passed storage names in the omni bencher to be known by FRAME metadata
8+
- Trim storage names in omni bencher to fix V1 bench syntax bug
9+
- Fix V1 bench syntax storage name sanitization for specific Rust versions
10+
11+
I re-ran the benchmarks with the omni-bencher modifications and it did not change the [proof size](https://weights.tasty.limo/compare?repo=polkadot-sdk&threshold=1&path_pattern=substrate%2Fframe%2F**%2Fsrc%2Fweights.rs%2Cpolkadot%2Fruntime%2F*%2Fsrc%2Fweights%2F**%2F*.rs%2Cpolkadot%2Fbridges%2Fmodules%2F*%2Fsrc%2Fweights.rs%2Ccumulus%2F**%2Fweights%2F*.rs%2Ccumulus%2F**%2Fweights%2Fxcm%2F*.rs%2Ccumulus%2F**%2Fsrc%2Fweights.rs&method=asymptotic&ignore_errors=true&unit=proof&old=cc0142510b81dcf1c1a22f7dc164c453c25287e6&new=bb19d78821eaeaf2262f6a23ee45f83dd4f94d29). I reverted [the commit](https://github.com/paritytech/polkadot-sdk/pull/7785/commits/bb19d78821eaeaf2262f6a23ee45f83dd4f94d29) afterwards to reduce the noise for reviewers.
12+
crates:
13+
- name: frame-benchmarking-cli
14+
bump: minor
15+
- name: frame-benchmarking
16+
bump: minor
17+
- name: pallet-scheduler
18+
bump: minor
19+
- name: asset-hub-westend-runtime
20+
bump: minor
21+
- name: westend-runtime
22+
bump: minor

0 commit comments

Comments
 (0)