Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move substrate-bip39 into polkadot-sdk #3579

Merged
merged 48 commits into from
Mar 7, 2024
Merged

move substrate-bip39 into polkadot-sdk #3579

merged 48 commits into from
Mar 7, 2024

Conversation

andresilva
Copy link
Contributor

Moves substrate-bip39 into substrate. All git history is preserved. Dependencies have been updated to use the same version as the rest of the repo.

Fixes #1934.

maciejhirsz and others added 30 commits February 22, 2019 18:15
@maciejhirsz
Initial commit
4cfedbe
@maciejhirsz
fix: Minor rewording
e447bf5
@maciejhirsz
Added test vectors
fc7fee2
@maciejhirsz
License and stuff for crates.io
0f45e0e
@maciejhirsz
Description in Cargo.toml
56c0ec3
@maciejhirsz
fix: Return MiniSecretKey instead of SecretKey
200a922
@maciejhirsz
Merge pull request #1 from paritytech/mh-return-minisecret
cd26df6 
Return MiniSecretKey instead of SecretKey
@gavofyork
Expose seed_from_entropy
0a46997
@gavofyork
Use master schnorrkel until Jeff fixes the typos
a288065
@stanislav-tkach
Use schnorrkel 0.1.0 version
a5d760a
@rphmeier
Merge pull request #3 from paritytech/stas-schnorrkel-0-1-0-version
080da45 
Use schnorrkel 0.1.0 version
@maciejhirsz
chore: Version bump (#4)
44307fd
@tomaka @maciejhirsz
We are a library, let's hide the Cargo.lock (#5)
62a78b9
@tomaka @maciejhirsz
Remove parallel feature from pbkdf2 (#6)
d8a1593
@maciejhirsz
Version bump
e4ade6d
@Demi-Marie
Update dependencies
c9cebeb
@bkchr
Release new version
c399d58
@bkchr
Release 0.3.1
61cc8db
@NikVolf
update schnorrkel
aa90dd2
@NikVolf
also bump version
fc0eccf
@bkchr
Merge pull request #8 from paritytech/nv-update-schnorrkel
68aace1 
Update schnorrkel to 0.9
@gnunicorn
Switch to Apache2 license (#9)
3d45ddb
@maciejhirsz
Version bump
8769b9c
@cheme
Zeroize secret buffer. (#10)
eef2f86 
* Zeroize secret buffer.

* spaces indent

* Update version for publishing
@adoerr
Update various outdated deps
f2d476d
@adoerr
Bump minor version
5ae2962
@bkchr
Merge pull request #11 from paritytech/ad-update-deps
c4bd2d2 
Update various outdated deps
@jasl
Downgrade schnorrkel
1a607c8
@jasl
Bump version
2a025c6
@bkchr
Merge pull request #12 from jasl/patch-2
c56994c 
Downgrade schnorrkel
@andresilva andresilva added R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”. labels Mar 5, 2024
@andresilva
Copy link
Contributor Author

CLA and check-publish will fail, both should be ignored IMO (although it means we'll need to force merge).

@michalkucharczyk
Copy link
Contributor

All git history is preserved

We will squash this while merging, so the history will not be available. Am I missing sth?

@andresilva
Copy link
Contributor Author

All git history is preserved

We will squash this while merging, so the history will not be available. Am I missing sth?

Contributions will be accounted for and it's easier to refer back to this PR to get full history. I can squash everything under a single import commit if you feel that it's useless though.

@paritytech paritytech deleted a comment from paritytech-cicd-pr Mar 5, 2024
@andresilva
Copy link
Contributor Author

andresilva commented Mar 5, 2024 •
edited
Loading

CLA and check-publish will fail, both should be ignored IMO (although it means we'll need to force merge).

check-publish can be fixed by publishing the crate with Parity Crate Owner before this PR gets merged (needs to be done otherwise this check fails in future PRs), I already bumped the version so should be good to go if we decide to move on with this. CLA not sure how to fix, either we ignore and force-merge, or we squash all commit history.

@michalkucharczyk
Copy link
Contributor

All git history is preserved

We will squash this while merging, so the history will not be available. Am I missing sth?

Contributions will be accounted for and it's easier to refer back to this PR to get full history. I can squash everything under a single import commit if you feel that it's useless though.

Keeping history in PR is fine.

@andresilva andresilva added this pull request to the merge queue Mar 7, 2024
This was referenced Mar 7, 2024
Closed
Closed
Closed
Merged via the queue into master with commit 30c32e3 Mar 7, 2024
129 of 130 checks passed
@andresilva andresilva deleted the andre/substrate-bip39 branch March 7, 2024 12:42
@burdges burdges mentioned this pull request Mar 7, 2024
Open
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@andresilva @maciejhirsz
@gavofyork @stanislav-tkach @rphmeier @tomaka @Demi-Marie @bkchr @NikVolf @gnunicorn @cheme @adoerr @jasl @nuke-web3 @michalkucharczyk
move substrate-bip39 into polkadot-sdk (paritytech#3579)
f7e6349 
Moves [substrate-bip39](https://github.com/paritytech/substrate-bip39)
into substrate. All git history is preserved. Dependencies have been
updated to use the same version as the rest of the repo.

Fixes paritytech#1934.

---------

Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: Gav Wood <[email protected]>
Co-authored-by: Stanislav Tkach <[email protected]>
Co-authored-by: Robert Habermeier <[email protected]>
Co-authored-by: Pierre Krieger <[email protected]>
Co-authored-by: Demi M. Obenour <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: NikVolf <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Benjamin Kampmann <[email protected]>
Co-authored-by: Maciej Hirsz <[email protected]>
Co-authored-by: cheme <[email protected]>
Co-authored-by: adoerr <[email protected]>
Co-authored-by: Jun Jiang <[email protected]>
Co-authored-by: Dan Shields <[email protected]>
Co-authored-by: Michal Kucharczyk <[email protected]>
This was referenced Jun 5, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Request] Move substrate-bip39 into polkadot-sdk monorepo