Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

from_string for Derive in no-std #10

Closed
2 tasks done
michalkucharczyk opened this issue May 5, 2023 · 3 comments
Closed
2 tasks done

from_string for Derive in no-std #10

michalkucharczyk opened this issue May 5, 2023 · 3 comments
Labels
I5-enhancement An additional feature request.

Comments

@michalkucharczyk
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

It is a follow-up of: paritytech/substrate#13027

Request

Proper implementation of from_string functions for Derive is still missing:
paritytech/substrate#13027 (comment),
paritytech/substrate@0e00dd6

Solution

No response

Are you willing to help with this request?

Yes!
@michalkucharczyk michalkucharczyk mentioned this issue May 5, 2023
Merged
@koute
Copy link
Contributor

koute commented May 8, 2023

Replying to @michalkucharczyk your comment from the PR:

Not sure what to do here: we could try to parse w/o regex

The regexps are not that complex; I'd probably just parse these by hand. Should be easy enough to make sure it's correct by just fuzzying the new implementation against the regex.

@koute koute changed the title from_string for Dervive in no-std from_string for Derive in no-std May 8, 2023
@bkchr
Copy link
Member

bkchr commented May 8, 2023

The regexps are not that complex; I'd probably just parse these by hand. Should be easy enough to make sure it's correct by just fuzzying the new implementation against the regex.

Yeah, I also already proposed the same to @michalkucharczyk. Some easy string search should be enough.

@the-right-joyce the-right-joyce transferred this issue from paritytech/substrate Aug 24, 2023
@the-right-joyce the-right-joyce added I5-enhancement An additional feature request. and removed J0-enhancement labels Aug 25, 2023
@michalkucharczyk
Copy link
Contributor Author

closed by: #2250

liuchengxu added a commit to subcoin-project/polkadot-sdk that referenced this issue Sep 20, 2024
@liuchengxu
Deploy user guide via mdbook (paritytech#10)
ab2fd8e 
* Add docs

* Build mdbook in CI

* Add getting_started.md

* Test

* .

* Add User Guide badge

* Nicer badge

* Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I5-enhancement An additional feature request.
Projects
SDK Node
Status: done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@koute @michalkucharczyk @bkchr @the-right-joyce