Implement Budget Distribution logic in pallet-dap by Ank4n · Pull Request #11527 · paritytech/polkadot-sdk

Ank4n · 2026-03-27T07:47:50Z

Stacked on #11513.
Extracted from #10844.

Overview

Adds issuance drip and budget distribution to pallet-dap. DAP becomes a generic inflation engine: it mints new tokens on a configurable cadence and distributes them to registered budget recipients.

No runtime behavior change: the existing chain configuration continues to mint via EraPayout trait in staking. DAP can be configured as a noop (cadence = 0 or empty budget).

Changes

pallet-dap

Issuance drip: drip_issuance() runs in on_initialize. Computes mint amount via IssuanceCurve (total issuance + elapsed time) and distributes to BudgetRecipients per a governance-updatable BudgetAllocation map that must sum to 100%.
Safety guards: MaxElapsedPerDrip ceiling prevents over-minting if the chain stalls. First-block initialization skips drip to avoid minting for an unknown period.
Buffer accounting: buffer's share is deactivated on inflow (mint + OnUnbalanced slashes).
set_budget_allocation extrinsic (root-only): validates keys match registered recipients and percentages sum to exactly 100%.
BudgetRecipient impl: DAP exposes its buffer as a recipient (key: "buffer").
Migration: MigrateV1ToV2 seeds LastIssuanceTimestamp and BudgetAllocation for existing chains. Not wired up in WAH or other runtimes yet.

TODOs

Wire benchmark weights.

In Later PR

Revert these changes

Ank4n · 2026-03-27T08:24:36Z

 	type Currency = Balances;
 	type PalletId = DapPalletId;
+	/// Noop — DAP does not mint until budget drip is enabled.
+	type IssuanceCurve = ();


minting disabled in this PR. Enabled with staking budget changes impl PR.

This reverts commit ff9f4a6.

Squashed commit of the following: commit 1b3ad0b Author: Alexandru Vasile <alexandru.vasile@parity.io> Date: Wed Apr 1 10:55:36 2026 +0000 Adjust metrics Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> commit 61d37db Author: Alexandru Vasile <alexandru.vasile@parity.io> Date: Wed Apr 1 09:58:38 2026 +0000 metrics: Bump some other buckets Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> commit ab2a221 Author: Alexandru Vasile <alexandru.vasile@parity.io> Date: Wed Apr 1 09:57:11 2026 +0000 collator-proto/metrics: Fix blindspot in collation fetch latency metrics Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io> commit 0d6888a Author: Ankan <10196091+Ank4n@users.noreply.github.com> Date: Wed Apr 1 00:18:21 2026 +0200 Implement Budget Distribution logic in pallet-dap (#11527) Stacked on #11513. Extracted from #10844. ## Overview Adds issuance drip and budget distribution to `pallet-dap`. DAP becomes a generic inflation engine: it mints new tokens on a configurable cadence and distributes them to registered budget recipients. No runtime behavior change: the existing chain configuration continues to mint via `EraPayout` trait in staking. DAP can be configured as a noop (cadence = 0 or empty budget). ## Changes ### pallet-dap - **Issuance drip**: `drip_issuance()` runs in `on_initialize`. Computes mint amount via `IssuanceCurve` (total issuance + elapsed time) and distributes to `BudgetRecipient`s per a governance-updatable `BudgetAllocation` map that must sum to 100%. - **Safety guards**: `MaxElapsedPerDrip` ceiling prevents over-minting if the chain stalls. First-block initialization skips drip to avoid minting for an unknown period. - **Buffer accounting**: buffer's share is deactivated on inflow (mint + `OnUnbalanced` slashes). - **`set_budget_allocation`** extrinsic (root-only): validates keys match registered recipients and percentages sum to exactly 100%. - **`BudgetRecipient` impl**: DAP exposes its buffer as a recipient (key: `"buffer"`). - **Migration**: `MigrateV1ToV2` seeds `LastIssuanceTimestamp` and `BudgetAllocation` for existing chains. Not wired up in WAH or other runtimes yet. ## TODOs - [x] Wire benchmark weights. ## In Later PR - Revert [these changes](9b388b2) --------- Co-authored-by: Paolo La Camera <paolo@parity.io> commit 8b53323 Author: Javier Viola <363911+pepoviola@users.noreply.github.com> Date: Tue Mar 31 21:26:58 2026 +0200 bump zombienet version to v0.4.9 (#11569) This version move the internal monitor to a diff log target, eliminating the current spam of tracing logs. Thx! --------- Co-authored-by: Bastian Köcher <git@kchr.de> commit 129a48a Author: Ankan <10196091+Ank4n@users.noreply.github.com> Date: Tue Mar 31 19:06:21 2026 +0200 [Staking] Add issuance and budget traits in prep for Budget Split (#11513) # Overview Moves `EraPayout` trait to `sp-staking` and adds new traits for issuance, budget distribution, and reward calculation. Extracted changes from the main PR: #10844 Also see: #11512 ## Changes ### sp-staking - `EraPayout`: moved from `pallet-staking` and `pallet-staking-async` to `sp-staking`, eliminating the duplicate definitions. - `budget` module: stake independent traits: - `IssuanceCurve`: successor to `EraPayout`, computes issuance from total supply + elapsed time (no staking state dependency). - `BudgetRecipient` / `BudgetRecipientList`: register pot accounts for inflation distribution. Runtime wires as a tuple. - `BudgetKey`: bounded identifier for budget categories. - `StakerRewardCalculator`: trait for calculating validator incentive weights and staker reward splits. ### pallet-staking / pallet-staking-async - Removed local `EraPayout` definitions, re-exported from `sp-staking`. --------- Co-authored-by: Paolo La Camera <paolo@parity.io> commit 10a517e Author: Dmitry Markin <dmitry@markin.tech> Date: Tue Mar 31 18:37:01 2026 +0300 Implement `bitswap_v1_get` RPC method (#11521) Implement `bitswap_v1_get` RPC method according to the [spec](https://github.com/paritytech/json-rpc-interface-spec/blob/main/src/api/bitswap_v1_get.md). --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Lukasz Rubaszewski <117115317+lrubasze@users.noreply.github.com> commit 2c99855 Author: Paolo La Camera <paolo@parity.io> Date: Tue Mar 31 16:42:03 2026 +0200 Fix can_inc_consumer check blocking session key rotation in pallet_session (#11573) Check consumer capacity only when we actually increment the consumer count (first-time local registration or external-to-local transition), not on key rotation. Notes: 1. setting keys via `stakingRcClient` didn't suffer of this issue since by-pass `do_set_keys()` 2. setting and purging keys via session pallet directly on RC is deprecated and will be removed soon - but better safe than sorry till then --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit de0a245 Author: Luka Ciric <luka.ciric2106@gmail.com> Date: Tue Mar 31 16:39:48 2026 +0200 Raise offence queue eras bound limit (#11435) Fixes a bug where **OffenceQueueEras** bound (BondingDuration) was incorrect when `SlashDeferDuration=0`. The oldest reportable offence era formula allowed more eras than the bound could hold. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ankan <10196091+Ank4n@users.noreply.github.com> Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Ank4n and others added 10 commits March 26, 2026 08:01

frontrunning traits

1d17819

dont deprecate yet

c3dc7e8

fmt

6f2742b

remov EraPayout from staking async

14e3aa9

remove EraRewardAllocation. It belongs in staking async

ddd01ec

move budget stuff to budget module

e14a388

remove AccountID from StakerRewardCalcualtor

187aa7f

Merge branch 'master' into ankn-sp-staking-traits

5075904

prdoc

4571f1f

extract dap changes from 10844

5eb51a5

Ank4n changed the title ~~extract dap changes from 10844~~ [DAP] Implement Budget Distribution logic in pallet-dap. Mar 27, 2026

Ank4n added the T2-pallets This PR/Issue is related to a particular pallet. label Mar 27, 2026

missing lock

0239e58

Ank4n changed the title ~~[DAP] Implement Budget Distribution logic in pallet-dap.~~ [WIP] Implement Budget Distribution logic in pallet-dap. Mar 27, 2026

Ank4n added 2 commits March 27, 2026 09:18

needs to be reverted when we integrate with staking changes

9b388b2

add default noop impl of issuance curve

cd7ede6

Ank4n changed the title ~~[WIP] Implement Budget Distribution logic in pallet-dap.~~ [WIP] Implement Budget Distribution logic in pallet-dap Mar 27, 2026

Ank4n commented Mar 27, 2026

View reviewed changes

Ank4n added 2 commits March 27, 2026 09:28

comment on consts

267a81e

prdoc

398b2cd

Ank4n marked this pull request as ready for review March 27, 2026 08:29

Ank4n requested a review from a team as a code owner March 27, 2026 08:29

Ank4n added 2 commits March 27, 2026 10:39

weights

da7abca

simplify

eecc058

Ank4n mentioned this pull request Mar 27, 2026

Move era reward minting to DAP with era-based allocation in Staking #10844

Closed

24 tasks

Ank4n changed the title ~~[WIP] Implement Budget Distribution logic in pallet-dap~~ Implement Budget Distribution logic in pallet-dap Mar 27, 2026

Ank4n added 2 commits March 27, 2026 11:21

update weights

f4f8a1f

fmt

9ec5124

Ank4n requested review from kianenigma and sigurpol March 27, 2026 10:30

Ank4n and others added 10 commits March 31, 2026 08:31

buffer_acc() only crate visibile

10536cc

always advance issue time

213ba52

use static parameter

941ada8

try state fail checks

435b08c

use u64 for account id

caf5524

no need to override acc id

ff9f4a6

Revert "no need to override acc id"

6a7c408

This reverts commit ff9f4a6.

fix rustdoc

c0d1609

Merge branch 'ankn-sp-staking-traits' into ankn-dap-budgets

7917bab

improve tests

7af0c6d

sigurpol approved these changes Mar 31, 2026

View reviewed changes

Ank4n added a commit that referenced this pull request Mar 31, 2026

squash: budget distribution logic #11527

cfa252f

Merge branch 'master' into ankn-sp-staking-traits

c6bbb0f

Ank4n mentioned this pull request Mar 31, 2026

[WIP] Staking with validator self stake incentive #11577

Closed

Ank4n and others added 6 commits March 31, 2026 14:22

Merge branch 'ankn-sp-staking-traits' into ankn-dap-budgets

3ce6cb2

Merge branch 'master' into ankn-sp-staking-traits

a30d654

Merge branch 'ankn-sp-staking-traits' into ankn-dap-budgets

9380b2d

fix ci

b466762

fmt

8b63957

fix clippy

195d8a1

Base automatically changed from ankn-sp-staking-traits to master March 31, 2026 18:48

Ank4n and others added 2 commits March 31, 2026 22:19

Merge branch 'master' into ankn-dap-budgets

8d80024

disable dap budget check

4795651

Ank4n enabled auto-merge March 31, 2026 20:59

another offering to CI Gods

d2b0eaa

Ank4n added this pull request to the merge queue Mar 31, 2026

Merged via the queue into master with commit 0d6888a Mar 31, 2026
214 of 216 checks passed

Ank4n deleted the ankn-dap-budgets branch March 31, 2026 23:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Budget Distribution logic in pallet-dap#11527

Implement Budget Distribution logic in pallet-dap#11527
Ank4n merged 44 commits intomasterfrom
ankn-dap-budgets

Ank4n commented Mar 27, 2026 •

edited

Loading

Uh oh!

Ank4n Mar 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Ank4n commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Changes

pallet-dap

TODOs

In Later PR

Uh oh!

Ank4n Mar 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Ank4n commented Mar 27, 2026 •

edited

Loading