Implement Budget Distribution logic in pallet-dap #11527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Ank4n merged 44 commits into master from ankn-dap-budgets

Mar 31, 2026

needs to be reverted when we integrate with staking changes

Ank4n committed Mar 27, 2026

commit 9b388b2da70c3a0dead7eb2cf2f29a3c9e89e714

substrate/frame/dap/src/lib.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -80,7 +80,7 @@ pub mod pallet { @@
     	use frame_system::pallet_prelude::*;
     	/// The in-code storage version.
-    	const STORAGE_VERSION: StorageVersion = StorageVersion::new(2);
+    	const STORAGE_VERSION: StorageVersion = StorageVersion::new(1);
     	#[pallet::pallet]
     	#[pallet::storage_version(STORAGE_VERSION)]
@@ Expand Down Expand Up / @@ -309,7 +309,13 @@ pub mod pallet { @@
     			// Distribute according to budget map.
     			let budget = BudgetAllocation::<T>::get();
     			if budget.is_empty() {
-    				defensive!("BudgetAllocation is empty — no issuance will be distributed");
+    				// TODO(ank4n): Add defensive! panic once budget is always configured.
+    				log::warn!(
+    					target: LOG_TARGET,
+    					"BudgetAllocation is empty — no issuance will be distributed"
+    				);
+    				LastIssuanceTimestamp::<T>::put(now);
+    				return T::DbWeight::get().reads_writes(4, 1);
     			}
     			let recipients = T::BudgetRecipients::recipients();
     			let mut total_minted = BalanceOf::<T>::zero();
@@ Expand Down @@

substrate/frame/dap/src/migrations.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -25,6 +25,9 @@ use frame_support::traits::UncheckedOnRuntimeUpgrade; @@
     /// - `T`: DAP pallet config
     /// - `P`: `Get<u64>` providing the initial timestamp (e.g. active era start from staking)
     /// - `B`: `Get<BudgetAllocationMap>` providing the initial budget allocation
+    ///
+    /// NOTE: This migration should be applied when staking changes are integrated to support
+    /// budget drip. The storage version bump (V1 → V2) happens at that point.
     pub type MigrateV1ToV2<T, P, B> = frame_support::migrations::VersionedMigration<
 ,
 ,
@@ Expand Down @@

substrate/frame/dap/src/tests/drip.rs

-Original file line number
+Diff line change
@@ Expand Up / @@ -101,14 +101,25 @@ fn drip_fires_after_cadence_reached() { @@
     }
     #[test]
-    #[should_panic(expected = "BudgetAllocation is empty")]
     fn no_drip_when_budget_not_set() {
     	build_and_execute(true, || {
+    		set_default_budget_allocation();
     		System::set_block_number(1);
-    		// GIVEN: no budget set (default empty map)
-    		// WHEN: drip fires — triggers defensive panic since empty budget is unexpected.
+    		// Clear the budget allocation.
+    		crate::BudgetAllocation::<Test>::kill();
+    		let staker_pot = 500u128;
+    		let balance_before = Balances::balance(&staker_pot);
+    		// WHEN: drip fires with empty budget — no panic, just early return.
     		advance_time_and_drip(60_000);
+    		// THEN: no funds distributed.
+    		assert_eq!(Balances::balance(&staker_pot), balance_before);
+    		// Restore for post-test try_state.
+    		set_default_budget_allocation();
     	});
     }
@@ Expand Down @@

Provide feedback