[stable2603] Backport #11417#11466
Merged
EgorPopelyaev merged 4 commits intostable2603from Mar 24, 2026
Merged
Conversation
…ate` (#11417) While testing the collator protocol revamp on westend I noticed "Inconsistency while adding a leaf to the `ClaimQueueState`. Expected on session change." pops up a lot at regular intervals. Long story short, when writing this code I assumed that the CQ never change but from a `ClaimQueueState` point of view this is not true. ~~On session change the validators in the active set are reshuffled and end up in different backing groups.~~ ON group rotation the validators are assigned on a new core. In this case we start fetching the claim queue for the newly assigned core and the future assignments in `ClaimQueueState` are no longer valid so overwriting them is the right thing to do. We could also implement a logic which detects assignment change, notifies the claim queue and cleans it up but it's an additional complexity which doesn't add any benefits. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 4afd7bd)
github-actions
Bot
added
the
A3-backport
Contributor
|
This pull request is amending an existing release. Please proceed with extreme caution,
Emergency Bypass
If you really need to bypass this check: add |
tdimitrov
approved these changes
Mar 23, 2026
alindima
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #11417 into
stable2603from tdimitrov.See the documentation on how to use this bot.