Decrease the log level for claim queue inconsistency in ClaimQueueState#11417
Merged
Decrease the log level for claim queue inconsistency in ClaimQueueState#11417
ClaimQueueState#11417Conversation
tdimitrov
added
A4-backport-stable2512
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
bkchr
approved these changes
Mar 18, 2026
sandreim
approved these changes
Mar 19, 2026
alindima
reviewed
Mar 23, 2026
alindima
approved these changes
Mar 23, 2026
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-11417-to-stable2512
git worktree add --checkout .worktree/backport-11417-to-stable2512 backport-11417-to-stable2512
cd .worktree/backport-11417-to-stable2512
git reset --hard HEAD^
git cherry-pick -x 4afd7bdd4b9e066f2d1da68b971f9938de214b3c
git push --force-with-lease |
paritytech-release-backport-bot Bot
pushed a commit
that referenced
this pull request
Mar 23, 2026
…ate` (#11417) While testing the collator protocol revamp on westend I noticed "Inconsistency while adding a leaf to the `ClaimQueueState`. Expected on session change." pops up a lot at regular intervals. Long story short, when writing this code I assumed that the CQ never change but from a `ClaimQueueState` point of view this is not true. ~~On session change the validators in the active set are reshuffled and end up in different backing groups.~~ ON group rotation the validators are assigned on a new core. In this case we start fetching the claim queue for the newly assigned core and the future assignments in `ClaimQueueState` are no longer valid so overwriting them is the right thing to do. We could also implement a logic which detects assignment change, notifies the claim queue and cleans it up but it's an additional complexity which doesn't add any benefits. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 4afd7bd)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Mar 24, 2026
Backport #11417 into `stable2603` from tdimitrov. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Tsvetomir Dimitrov <tsvetomir@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the collator protocol revamp on westend I noticed "Inconsistency while adding a leaf to the
ClaimQueueState. Expected on session change." pops up a lot at regular intervals.Long story short, when writing this code I assumed that the CQ never change but from a
ClaimQueueStatepoint of view this is not true.On session change the validators in the active set are reshuffled and end up in different backing groups.ON group rotation the validators are assigned on a new core. In this case we start fetching the claim queue for the newly assigned core and the future assignments inClaimQueueStateare no longer valid so overwriting them is the right thing to do.We could also implement a logic which detects assignment change, notifies the claim queue and cleans it up but it's an additional complexity which doesn't add any benefits.