Skip to content

[stable2603] Backport #11152#11298

Merged
lrubasze merged 2 commits intostable2603from
backport-11152-to-stable2603
Mar 6, 2026
Merged

[stable2603] Backport #11152#11298
lrubasze merged 2 commits intostable2603from
backport-11152-to-stable2603

Conversation

@paritytech-release-backport-bot
Copy link
Copy Markdown

@paritytech-release-backport-bot paritytech-release-backport-bot Bot commented Mar 6, 2026

Backport #11152 into stable2603 from skunert.

This PR fixes the downtime, which might happen after completed warp and gap sync.

See the documentation on how to use this bot.

@paritytech-release-backport-bot
Copy link
Copy Markdown
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-11152-to-stable2603
git worktree add --checkout .worktree/backport-11152-to-stable2603 backport-11152-to-stable2603
cd .worktree/backport-11152-to-stable2603
git reset --hard HEAD^
git cherry-pick -x 44a03f017e2610f163c9ac26dee7ba158418384f
git push --force-with-lease

@github-actions github-actions Bot added the A3-backport Pull request is already reviewed well in another branch. label Mar 6, 2026
@github-actions github-actions Bot requested a review from skunert March 6, 2026 13:59
While warp syncing a node, I saw some huge stalls. What happens:

- During warp sync we store warp proofs
- After warp sync we start gap sync
- Problem: Once gap sync finishes, node starts looking for displaced
leaves from all the warp proof blocks, which was over 2500 in my
observed case. This led to a 30minutes stall.

In this PR I propose to import the blocks during warp sync with a
Disconnected state, which does not add them as leaves. This fixes the
downtime.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 44a03f0)
@lrubasze lrubasze force-pushed the backport-11152-to-stable2603 branch from fda6fe7 to 86f3762 Compare March 6, 2026 14:05
@lrubasze lrubasze marked this pull request as ready for review March 6, 2026 14:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 6, 2026

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@lrubasze lrubasze merged commit e28175c into stable2603 Mar 6, 2026
379 of 385 checks passed
@lrubasze lrubasze deleted the backport-11152-to-stable2603 branch March 6, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A3-backport Pull request is already reviewed well in another branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants