Warp sync: Warp proof block import should not mark as leaf#11152
Merged
Warp sync: Warp proof block import should not mark as leaf#11152
Conversation
skunert
added
T0-node
Contributor
Author
|
/cmd prdoc --audience node_dev --bump major |
Contributor
Author
|
/cmd fmt |
bkchr
approved these changes
Feb 24, 2026
lexnv
approved these changes
Feb 25, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
lrubasze
pushed a commit
that referenced
this pull request
Mar 4, 2026
While warp syncing a node, I saw some huge stalls. What happens: - During warp sync we store warp proofs - After warp sync we start gap sync - Problem: Once gap sync finishes, node starts looking for displaced leaves from all the warp proof blocks, which was over 2500 in my observed case. This led to a 30minutes stall. In this PR I propose to import the blocks during warp sync with a Disconnected state, which does not add them as leaves. This fixes the downtime. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
lrubasze
added
the
A4-backport-stable2603
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-11152-to-stable2603
git worktree add --checkout .worktree/backport-11152-to-stable2603 backport-11152-to-stable2603
cd .worktree/backport-11152-to-stable2603
git reset --hard HEAD^
git cherry-pick -x 44a03f017e2610f163c9ac26dee7ba158418384f
git push --force-with-lease |
lrubasze
pushed a commit
that referenced
this pull request
Mar 6, 2026
While warp syncing a node, I saw some huge stalls. What happens: - During warp sync we store warp proofs - After warp sync we start gap sync - Problem: Once gap sync finishes, node starts looking for displaced leaves from all the warp proof blocks, which was over 2500 in my observed case. This led to a 30minutes stall. In this PR I propose to import the blocks during warp sync with a Disconnected state, which does not add them as leaves. This fixes the downtime. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit 44a03f0)
lrubasze
added a commit
that referenced
this pull request
Mar 6, 2026
Backport #11152 into `stable2603` from skunert. This PR fixes the downtime, which might happen after completed warp and gap sync. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Sebastian Kunert <skunert49@gmail.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Lukasz Rubaszewski <117115317+lrubasze@users.noreply.github.com>
github-project-automation
Bot
moved this from Todo
to Done
in [preview] release tracker
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While warp syncing a node, I saw some huge stalls. What happens:
In this PR I propose to import the blocks during warp sync with a Disconnected state, which does not add them as leaves. This fixes the downtime.