Add statement store e2e integration tests by DenzelPenzel · Pull Request #11237 · paritytech/polkadot-sdk

DenzelPenzel · 2026-03-03T11:36:59Z

Description

#10783

E2E Integration Tests (zombienet-sdk)

Functional tests (statement_store)

statement_store_genesis_inject — submit + subscribe round-trip with genesis-injected allowances, 2-node propagation with data
integrity verification
statement_store_sudo_allowance — sudo-based runtime allowance setting, 8 concurrent multi-account submissions, 4-node fan-out propagation

Test Infrastructure

common.rs — shared helpers: create_test_statement, submit_statement, expect_one_statement, expect_statements_unordered,
subscribe_topic, spawn_network, spawn_network_sudo
sc_statement_store::subxt_client — custom subxt config (CustomConfig) for non-standard transaction extensions
(VerifyMultiSignature, RestrictOrigins), set_allowances_via_sudo for runtime-configured networks
sc_statement_store::test_utils — shared keypair generation and allowance storage item builders (get_keypair,
create_allowance_items, create_uniform_allowance_items)
CI matrix registration for all statement store test groups

What we cover in this PR

Test(statement_store_sudo_allowance) cover the next options for #11534 :

Propagation under normal load: Zombienet tests to cover concurrent multi-client corner cases and verify statements reach all real nodes, NOT including during major sync

DenzelPenzel · 2026-03-03T13:49:25Z

/cmd prdoc

alexggh

Nice, thank you @DenzelPenzel !

…on-tests

DenzelPenzel · 2026-03-30T14:47:24Z

/cmd fmt

AndreiEres

Everything is good, just minor changes requested

DenzelPenzel · 2026-04-01T10:40:04Z

/cmd fmt

AndreiEres

Let's get it merged!

…on-tests

Squashed commit of the following: commit e9ab097 Author: eskimor <robert@gonimo.com> Date: Fri Apr 3 00:53:19 2026 +0200 Pr doc commit ef9dfac Author: eskimor <robert@gonimo.com> Date: Fri Apr 3 00:41:08 2026 +0200 Fix warning commit 076e7e9 Author: eskimor <robert@gonimo.com> Date: Fri Apr 3 00:09:28 2026 +0200 Tests commit cdfc57c Author: eskimor <robert@gonimo.com> Date: Fri Apr 3 00:09:03 2026 +0200 Fix test commit a1a2bbf Author: clangenb <37865735+clangenb@users.noreply.github.com> Date: Thu Apr 2 22:55:34 2026 +0200 Fix slot-based collator panic during warp sync (#11072) (#11381) When a parachain collator starts with `--authoring=slot-based` and performs warp sync, the `slot-based-block-builder` essential task immediately calls `slot_duration()` which requires `AuraApi_slot_duration`. During warp sync the runtime isn't ready, so this fails and the task returns, shutting down the node. The lookahead collator avoids this by calling `wait_for_aura()` before starting. This PR adds an equivalent guard to the slot-based collator. ### Manual test Before the fix the collator panicked after the relay chain warp sync with AuraApi_slot_duration not available, which does not occur anymore now. ``` ./target/release/polkadot-parachain \ --chain asset-hub-polkadot \ --sync warp \ --authoring=slot-based \ --tmp -- --sync warp ``` Closes #11072. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: clangenb <clangenb@users.noreply.github.com> commit 802db0b Author: 0xRVE <robertvaneerdewijk@gmail.com> Date: Thu Apr 2 16:39:00 2026 +0300 [pallet-revive] Add vesting precompile (#11398) ## Summary Adds a new built-in precompile (`pallet-revive-precompile-vesting`) that exposes Substrate's `pallet-vesting` to EVM contracts via pallet-revive. EVM contracts can call `vest()`, `vestOther(address)`, `vestingBalance()`, and `vestingBalanceOf(address)` at the precompile address `0x0902`. ## Changes - **`substrate/frame/revive/uapi/sol/IVesting.sol`**: New Solidity interface defining the vesting precompile ABI - **`substrate/frame/revive/uapi/src/precompiles/vesting.rs`**: Binds the Solidity interface via `alloy_core::sol!` - **`substrate/frame/revive/precompiles/`**: New crate implementing the `Precompile` trait — dispatches `vest`/`vestOther` through `pallet_vesting` and queries locked balances via `VestingSchedule` - **`substrate/frame/revive/src/tests.rs`**: Trailing comma fix in `construct_runtime!` ## Test plan - [x] New vesting precompile tests pass (`vest`, `vestOther`, `vestingBalance`, `vestingBalanceOf`) - [x] Existing pallet-revive tests unaffected --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: PG Herveou <pgherveou@gmail.com> commit 5fbeadd Author: Dhiraj Sah <dhiraj@parity.io> Date: Thu Apr 2 17:35:52 2026 +0530 fix(pallet-multi-asset-bounties): use non-destructive read in calculate_payout() (#11425) ## Description `calculate_payout()` in `pallet-multi-asset-bounties` uses `ChildBountiesValuePerParent::take()` — a destructive read that deletes the storage entry — instead of `get()`. Since `calculate_payout()` is called from multiple code paths, the `take()` causes incorrect behavior on subsequent calls. `calculate_payout()` is called from two places: 1. `do_process_payout_payment()` (lib.rs:1736) — invoked by `award_bounty()` and `retry_payment()` 2. `do_check_payout_payment_status()` (lib.rs:1771) — invoked by `check_status()` on payment success When a parent bounty with child bounties is awarded: - The **first call** (from `award_bounty()`) reads `ChildBountiesValuePerParent` via `take()`, correctly computing `parent_value - children_value`, but **deletes the storage entry** as a side effect. - The **second call** (from `check_status()` on success) reads the now-deleted storage, gets `0`, and emits `BountyPayoutProcessed` with `value: parent_value` instead of the correct `value: parent_value - children_value`. Additionally, if a non-synchronous `Paymaster` implementation is used where `check_payment()` can return `Failure`, the `retry_payment()` path would call `calculate_payout()` again on the deleted storage, attempting to pay the full parent value instead of the reduced amount. ## Integration No integration changes required for downstream projects. This is a bugfix internal to `pallet-multi-asset-bounties` with no changes to public APIs, storage layout, or trait definitions. ## Review Notes Three changes were made: ### 1. `calculate_payout()` — `take()` replaced with `get()` ```diff - let children_value = ChildBountiesValuePerParent::<T, I>::take(parent_bounty_id); + let children_value = ChildBountiesValuePerParent::<T, I>::get(parent_bounty_id); ``` This makes `calculate_payout()` idempotent — safe to call multiple times for the same bounty. ### 2. `remove_bounty()` — explicit storage cleanup added ```diff None => { Bounties::<T, I>::remove(parent_bounty_id); ChildBountiesPerParent::<T, I>::remove(parent_bounty_id); TotalChildBountiesPerParent::<T, I>::remove(parent_bounty_id); - debug_assert!(ChildBountiesValuePerParent::<T, I>::get(parent_bounty_id).is_zero()); + ChildBountiesValuePerParent::<T, I>::remove(parent_bounty_id); }, ``` The `debug_assert!` was removed because it was not a true invariant — it only passed because `take()` had already deleted the value. When child bounties are paid out, `ChildBountiesValuePerParent` remains non-zero until parent bounty cleanup. ### 3. Test updated Added an event assertion to the existing `check_status_works` test to verify `BountyPayoutProcessed` emits the correct net payout value (`parent_value - child_value`) instead of the full parent value. This assertion fails with `take()` and passes with `get()`. ### Impact - **Current deployments (KAH, PAH)**: Both use `LocalPay` where `check_payment()` always returns `Success`. The retry/lock path is unreachable, but the `BountyPayoutProcessed` event emits an incorrect payout value for parent bounties with child bounties. - **Future deployments**: If the pallet is configured with an async `Paymaster` (e.g., XCM-based) where `check_payment()` can return `Failure`, the `retry_payment()` path would compute a wrong payout amount, potentially leading to permanent fund lock with no recovery path (since `close_bounty()` rejects `PayoutAttempted` status). --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit e3865cf Author: Rodrigo Quelhas <22591718+RomarQ@users.noreply.github.com> Date: Thu Apr 2 10:41:38 2026 +0100 Deprecate `ValidateUnsigned` trait and `#[pallet::validate_unsigned]` attribute (#10150) Part of #2415 Closes #2436 Related: #6325 #6326 ## Summary Deprecates the `ValidateUnsigned` trait and `#[pallet::validate_unsigned]` attribute in favor of the new `TransactionExtension` API. This is a non-breaking change that adds deprecation warnings to guide users toward the modern transaction validation approach. ## Motivation The `ValidateUnsigned` trait was the legacy approach for validating unsigned transactions in FRAME pallets. The newer `TransactionExtension` trait provides a more flexible and composable way to handle transaction validation, including both signed and unsigned transactions. ## Changes ### Deprecated APIs - ✅ Added `#[deprecated]` attribute to `ValidateUnsigned` trait - ✅ Added deprecation warning to `#[pallet::validate_unsigned]` macro attribute ### Migration (Using `TransactionExtensions`) https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/reference_docs/transaction_extensions ## Impact - **Non-breaking:** Existing code continues to work with deprecation warnings - **Compiler warnings:** Users will see deprecation notices guiding them to migrate - **Timeline:** Full removal planned for a future major release (TBD) ## Review Notes - The `#[pallet::validate_unsigned]` deprecation warning might be redundant since it's always used together with `ValidateUnsigned`, but both are included for completeness and clarity. ## Follow-up Tasks The following pallets and crates need to be migrated to `TransactionExtension` in subsequent PRs: **Runtime crates:** - [ ] `polkadot-runtime-common` - [ ] `polkadot-runtime-parachains` **FRAME pallets:** - [ ] `pallet-babe` - [ ] `pallet-beefy` - [ ] `pallet-election-provider-multi-block` - [ ] `pallet-grandpa` - [x] `pallet-im-online` #11235 - [x] `pallet-mixnet` #11010 **Core:** - [ ] `frame-executive` - [ ] `frame-system` **Examples:** - [x] `pallet-example-offchain-worker` #10716 **Testing:** - [ ] `substrate-test-runtime` ## Open Question Should we remove the `ValidateUnsigned` bound from the type parameter `V` in the `Applyable` trait? --------- Co-authored-by: Guillaume Thiolliere <guillaume.thiolliere@parity.io> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> commit 5c97c0f Author: clangenb <37865735+clangenb@users.noreply.github.com> Date: Thu Apr 2 01:06:59 2026 +0200 [Penpal] fix genesis presets - assign proper ED to accounts (#11575) Penpal had values below the ED for initializing asset balances for some accounts. This has not been detected as no unit tests actually use the presets. This PR fixes the invalid values, and it also adds some unit tests for validating that the presets build at least. Closes #11558. --------- Co-authored-by: clangenb <clangenb@users.noreply.github.com> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 59c4053 Author: Egor_P <egor@parity.io> Date: Wed Apr 1 20:29:31 2026 +0200 [Release|CI/CD] Fixes for release flows (#11578) This PR backports few fixes for soem release flows, that were made in stable2603 branch. In particular: - Fixed resume check in Crates Publish flow - Fixed missing llvm path on macos builds - Fixed scrtipt that reverts path deps in Cargo.toml files - Bumped parity-publish version - Fixed check if the post-crates-release branch exists in Crateds Publish flow --------- Co-authored-by: BDevParity <bruno.devic@parity.io> commit e9e4769 Author: DenzelPenzel <15388928+DenzelPenzel@users.noreply.github.com> Date: Wed Apr 1 14:11:28 2026 +0100 Add statement store e2e integration tests (#11237) # Description #10783 E2E Integration Tests (zombienet-sdk) Functional tests (statement_store) - statement_store_genesis_inject — submit + subscribe round-trip with genesis-injected allowances, 2-node propagation with data integrity verification - statement_store_sudo_allowance — sudo-based runtime allowance setting, 8 concurrent multi-account submissions, 4-node fan-out propagation ### Test Infrastructure - common.rs — shared helpers: create_test_statement, submit_statement, expect_one_statement, expect_statements_unordered, subscribe_topic, spawn_network, spawn_network_sudo - sc_statement_store::subxt_client — custom subxt config (CustomConfig) for non-standard transaction extensions (VerifyMultiSignature, RestrictOrigins), set_allowances_via_sudo for runtime-configured networks - sc_statement_store::test_utils — shared keypair generation and allowance storage item builders (get_keypair, create_allowance_items, create_uniform_allowance_items) - CI matrix registration for all statement store test groups ### What we cover in this PR Test(statement_store_sudo_allowance) cover the next options for #11534 : - Propagation under normal load: Zombienet tests to cover concurrent multi-client corner cases and verify statements reach all real nodes, NOT including during major sync --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit a41bb09 Author: Javier Viola <363911+pepoviola@users.noreply.github.com> Date: Wed Apr 1 14:34:27 2026 +0200 [zombienet] typo in preflight (#11602) Typo in the preflight logic was merged by accident. Thx! Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>

Add statement store e2e integration tests

bf93160

DenzelPenzel added the R0-no-crate-publish-required The change does not require any crates to be re-published. label Mar 3, 2026

DenzelPenzel requested review from a team as code owners March 3, 2026 11:36

DenzelPenzel added the T10-tests This PR/Issue is related to tests. label Mar 3, 2026

Update from github-actions[bot] running command 'fmt'

4571a2f

DenzelPenzel requested review from AndreiEres and alexggh March 3, 2026 12:43

DenzelPenzel added R0-no-crate-publish-required The change does not require any crates to be re-published. and removed R0-no-crate-publish-required The change does not require any crates to be re-published. labels Mar 3, 2026

Update from github-actions[bot] running command 'prdoc'

794bd8c

alexggh reviewed Mar 3, 2026

View reviewed changes

Comment thread cumulus/zombienet/zombienet-sdk/tests/zombie_ci/statement_store_bench.rs Outdated

statement-store: added commons

3ba371d

DenzelPenzel requested a review from alexggh March 5, 2026 10:11

DenzelPenzel and others added 6 commits March 5, 2026 11:02

statement-store: fmt

607ba20

statement-store: fix clippy issues

4c2df23

statement-store: update min subscriptions calc

81dbfd5

statement-store: sudo allowance e2e

643ea61

Merge branch 'master' into denzelpenzel/statement-store-e2e-integrati…

10dc27d

…on-tests

statement-store: custom suxt config

4199bed

DenzelPenzel force-pushed the denzelpenzel/statement-store-e2e-integration-tests branch 3 times, most recently from a1b273d to 98fb702 Compare March 6, 2026 16:29

statement-store: add common helpers

94f0290

DenzelPenzel force-pushed the denzelpenzel/statement-store-e2e-integration-tests branch from 98fb702 to 94f0290 Compare March 6, 2026 17:18

DenzelPenzel added 2 commits March 6, 2026 18:07

statement-store: matrix workflow

400a25a

statement-store: fmt

eb5ff1d

DenzelPenzel force-pushed the denzelpenzel/statement-store-e2e-integration-tests branch from dbe9962 to eb5ff1d Compare March 6, 2026 19:58

statement-store: update the chainspec

d848650

statement-store: consolidate e2e tests and extract shared helpers

d0cf877

DenzelPenzel force-pushed the denzelpenzel/statement-store-e2e-integration-tests branch from c39a9a2 to d0cf877 Compare March 30, 2026 12:16

DenzelPenzel and others added 4 commits March 30, 2026 13:22

statement-store: update pr doc

a92885b

Update from github-actions[bot] running command 'fmt'

0622f54

statement-store: update chainspec

9cd0ec9

statement-store: update chainspec

843b160

DenzelPenzel force-pushed the denzelpenzel/statement-store-e2e-integration-tests branch from 0bc8b45 to 843b160 Compare March 30, 2026 14:45

Update from github-actions[bot] running command 'fmt'

5c15982

DenzelPenzel force-pushed the denzelpenzel/statement-store-e2e-integration-tests branch from 3a71ce1 to 5c15982 Compare March 30, 2026 15:31

DenzelPenzel added 2 commits March 30, 2026 18:31

statement-store: update chainspec

ac27750

statement-store: strengthen concurrent propagation integration test

395aa10

alexggh approved these changes Apr 1, 2026

View reviewed changes

Comment thread cumulus/zombienet/zombienet-sdk/tests/zombie_ci/statement_store/integration.rs Outdated

Comment thread cumulus/zombienet/zombienet-sdk/tests/zombie_ci/statement_store/people-westend-local-spec.json

AndreiEres requested changes Apr 1, 2026

View reviewed changes

AndreiEres mentioned this pull request Apr 1, 2026

statement-store: close correctness test coverage gaps #11534

Open

13 tasks

statement-store: address review feedback on e2e integration tests

a94acba

DenzelPenzel requested a review from AndreiEres April 1, 2026 10:41

github-actions Bot and others added 2 commits April 1, 2026 10:42

Update from github-actions[bot] running command 'fmt'

ddbf7ff

statement-store: update CI matrix test names to match renamed functions

b839710

DenzelPenzel force-pushed the denzelpenzel/statement-store-e2e-integration-tests branch from 8d11548 to b839710 Compare April 1, 2026 10:49

AndreiEres approved these changes Apr 1, 2026

View reviewed changes

alvicsam approved these changes Apr 1, 2026

View reviewed changes

Merge branch 'master' into denzelpenzel/statement-store-e2e-integrati…

aca36b7

…on-tests

DenzelPenzel enabled auto-merge April 1, 2026 11:41

DenzelPenzel added this pull request to the merge queue Apr 1, 2026

Merged via the queue into master with commit e9e4769 Apr 1, 2026
213 of 216 checks passed

DenzelPenzel deleted the denzelpenzel/statement-store-e2e-integration-tests branch April 1, 2026 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add statement store e2e integration tests#11237

Add statement store e2e integration tests#11237
DenzelPenzel merged 41 commits intomasterfrom
denzelpenzel/statement-store-e2e-integration-tests

DenzelPenzel commented Mar 3, 2026 •

edited

Loading

Uh oh!

DenzelPenzel commented Mar 3, 2026

Uh oh!

alexggh left a comment

Uh oh!

Uh oh!

DenzelPenzel commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

AndreiEres left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DenzelPenzel commented Apr 1, 2026

Uh oh!

AndreiEres left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

DenzelPenzel commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Infrastructure

What we cover in this PR

Uh oh!

DenzelPenzel commented Mar 3, 2026

Uh oh!

alexggh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DenzelPenzel commented Mar 30, 2026

Uh oh!

Uh oh!

Uh oh!

AndreiEres left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DenzelPenzel commented Apr 1, 2026

Uh oh!

AndreiEres left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DenzelPenzel commented Mar 3, 2026 •

edited

Loading