Conversation
x3c41a
commented
Nov 25, 2025
9 tasks
x3c41a
commented
Nov 26, 2025
x3c41a
commented
Nov 26, 2025
x3c41a
commented
Nov 26, 2025
bkontur
reviewed
Nov 26, 2025
Comment on lines
+91
to
+95
| let version_num: u64 = cid.version().into(); | ||
| let size = cid.hash().size() as usize; | ||
| let code = cid.hash().code(); | ||
| let cid_str = cid.to_string(); | ||
| self.is_valid_cid(version_num, size, code, cid_str) |
Contributor
There was a problem hiding this comment.
Suggested change
| let version_num: u64 = cid.version().into(); | |
| let size = cid.hash().size() as usize; | |
| let code = cid.hash().code(); | |
| let cid_str = cid.to_string(); | |
| self.is_valid_cid(version_num, size, code, cid_str) | |
| self.is_cid_supported(&cid) |
bkontur
reviewed
Nov 28, 2025
bkontur
reviewed
Nov 28, 2025
bkontur
reviewed
Nov 28, 2025
x3c41a
force-pushed
the
cid_filtering
branch
from
9d9bee3 to
baa2427
Compare
bkontur
reviewed
Dec 2, 2025
bkontur
reviewed
Dec 2, 2025
bkontur
approved these changes
Dec 2, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
1 similar comment
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
dmitry-markin
approved these changes
Dec 2, 2025
bkontur
reviewed
Dec 2, 2025
bkontur
added
the
A4-backport-stable2512
|
Successfully created backport PR for |
paritytech-release-backport-bot Bot
pushed a commit
that referenced
this pull request
Dec 3, 2025
Relates to paritytech/litep2p#482 TODO: - [x] bump new litep2p version once it's released --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com> (cherry picked from commit c5560a2)
bkontur
added a commit
that referenced
this pull request
Dec 9, 2025
Backport #10416 into `stable2512` from x3c41a. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Andrii <ndk@parity.io> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Branislav Kontur <bkontur@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to paritytech/litep2p#482
TODO: