Skip to content

frame-system: Ensure that BlockNumber is strictly increasing#10180

Merged
bkchr merged 8 commits intomasterfrom
bkchr-system-strictly-increasing
Nov 6, 2025
Merged

frame-system: Ensure that BlockNumber is strictly increasing#10180
bkchr merged 8 commits intomasterfrom
bkchr-system-strictly-increasing

Conversation

@bkchr
Copy link
Copy Markdown
Member

@bkchr bkchr commented Oct 31, 2025

Otherwise a block should fail to build/import.

@bkchr
frame-system: Ensure that BlockNumber is strictly increasing
26b6eb3 
Otherwise a block should fail to build/import.
@bkchr bkchr requested a review from a team as a code owner October 31, 2025 22:09
@bkchr bkchr added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 31, 2025
@bkchr
Copy link
Copy Markdown
Member Author

bkchr commented Oct 31, 2025

/cmd prdoc --audience runtime_dev --bump patch

@paritytech-workflow-stopper
Copy link
Copy Markdown

paritytech-workflow-stopper bot commented Nov 5, 2025

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/19109547910
Failed job name: run-frame-omni-bencher

@bkchr
Copy link
Copy Markdown
Member Author

bkchr commented Nov 6, 2025

/cmd fmt

@bkchr bkchr added this pull request to the merge queue Nov 6, 2025
Merged via the queue into master with commit 12f9d59 Nov 6, 2025
264 of 275 checks passed
@bkchr bkchr deleted the bkchr-system-strictly-increasing branch November 6, 2025 14:26
@bkchr bkchr added A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-stable2509 Pull request must be backported to the stable2509 release branch labels Nov 6, 2025
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot bot commented Nov 6, 2025

Created backport PR for stable2506:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10180-to-stable2506
git worktree add --checkout .worktree/backport-10180-to-stable2506 backport-10180-to-stable2506
cd .worktree/backport-10180-to-stable2506
git reset --hard HEAD^
git cherry-pick -x 12f9d5987303545220466c62fa5e0621abc72025
git push --force-with-lease

@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Nov 6, 2025
Merged
@paritytech-release-backport-bot
Copy link
Copy Markdown

paritytech-release-backport-bot bot commented Nov 6, 2025

Created backport PR for stable2509:

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-10180-to-stable2509
git worktree add --checkout .worktree/backport-10180-to-stable2509 backport-10180-to-stable2509
cd .worktree/backport-10180-to-stable2509
git reset --hard HEAD^
git cherry-pick -x 12f9d5987303545220466c62fa5e0621abc72025
git push --force-with-lease

@paritytech-release-backport-bot paritytech-release-backport-bot bot mentioned this pull request Nov 6, 2025
Merged
bkchr added a commit that referenced this pull request Nov 6, 2025
@bkchr @github-actions
frame-system: Ensure that BlockNumber is strictly increasing (#10180)
315ca63 
Otherwise a block should fail to build/import.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pgherveou
Copy link
Copy Markdown
Contributor

pgherveou commented Nov 6, 2025

@bkchr

team member reported this

2025-11-06 16:37:20.850 ERROR      offchain-worker runtime: panicked at /Users/robert/polkadot-sdk/substrate/frame/system/src/lib.rs:1916:3:
assertion `left == right` failed: Block number must be strictly increasing.
  left: 2
 right: 1
2025-11-06 16:37:20.851 ERROR      offchain-worker offchain-worker: Error running offchain workers at 0x2264734e5b4cc6fe29385b6d574c32830f7b7e045588a1edf5b9949f7aae5755: Execution failed: Execution aborted due to trap: wasm trap: wasm `unreachable` instru
ction executed
WASM backtrace:
error while executing at wasm backtrace:
    0: 0x2b3671 - revive_dev_runtime.wasm!__rustc[5224e6b81cd82a8f]::rust_begin_unwind
    1:  0x1f106 - revive_dev_runtime.wasm!core::panicking::panic_fmt::hc4e5121f822df63e
    2:  0x1f3a6 - revive_dev_runtime.wasm!core::panicking::assert_failed_inner::h4f260632bc718f35
    3:  0x4fd06 - revive_dev_runtime.wasm!core::panicking::assert_failed::hf4acac8520b9fbad
    4: 0x1ac1a5 - revive_dev_runtime.wasm!frame_system::<impl frame_system::pallet::Pallet<T>>::initialize::h930c70874146ee2d
    5: 0x21539d - revive_dev_runtime.wasm!frame_executive::Executive<System,Block,Context,UnsignedValidator,AllPalletsWithSystem,COnRuntimeUpgrade>::offchain_worker::h569646f48af8d586
    6: 0x1cae96 - revive_dev_runtime.wasm!OffchainWorkerApi_offchain_worker

haven't investigated yet, just letting you know as this seems related to these changes

@bkchr
Copy link
Copy Markdown
Member Author

bkchr commented Nov 6, 2025

I will take a look. Ty for posting.

@0xRVE
Copy link
Copy Markdown
Contributor

0xRVE commented Nov 6, 2025 •
edited
Loading

@bkchr
Happened in revive-dev-node. Let me know if you need me to reproduce

marian-radu pushed a commit that referenced this pull request Nov 6, 2025
@bkchr @github-actions @marian-radu
frame-system: Ensure that BlockNumber is strictly increasing (#10180)
2a7cb4e 
Otherwise a block should fail to build/import.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bkchr added a commit that referenced this pull request Nov 6, 2025
@bkchr
offchain-worker: Do not intialize the entire System again
3378aec 
When calling `offchain-worker` we were initializing the entire `System` again with the same block we are running on top of. However, with [the change to require strictly increasing block numbers](#10180) the
offchain-worker was failing. This is now solved by just registering the missing digests. The rest of the changes done by `initialize` are not important for offchain workers.

The pull request ensures that we are actually testing this behavior of the offchain worker now.
@bkchr bkchr mentioned this pull request Nov 6, 2025
Merged
@bkchr
Copy link
Copy Markdown
Member Author

bkchr commented Nov 6, 2025

Fixed here: #10235

EgorPopelyaev added a commit that referenced this pull request Nov 10, 2025
@paritytech-release-backport-bot @bkchr
@github-actions @EgorPopelyaev
[stable2506] Backport #10180 (#10228)
9f87984 
Backport #10180 into `stable2506` from bkchr.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bastian Köcher <info@kchr.de>
Co-authored-by: Egor_P <egor@parity.io>
github-merge-queue bot pushed a commit that referenced this pull request Nov 10, 2025
@bkchr @github-actions
offchain-worker: Do not intialize the entire System again (#10235)
405e0bd 
When calling `offchain-worker` we were initializing the entire `System`
again with the same block we are running on top of. However, with [the
change to require strictly increasing block
numbers](#10180) the
offchain-worker was failing. This is now solved by just registering the
missing digests. The rest of the changes done by `initialize` are not
important for offchain workers.

The pull request ensures that we are actually testing this behavior of
the offchain worker now.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
paritytech-release-backport-bot bot pushed a commit that referenced this pull request Nov 10, 2025
@bkchr @github-actions
offchain-worker: Do not intialize the entire System again (#10235)
01db05e 
When calling `offchain-worker` we were initializing the entire `System`
again with the same block we are running on top of. However, with [the
change to require strictly increasing block
numbers](#10180) the
offchain-worker was failing. This is now solved by just registering the
missing digests. The rest of the changes done by `initialize` are not
important for offchain workers.

The pull request ensures that we are actually testing this behavior of
the offchain worker now.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 405e0bd)
paritytech-release-backport-bot bot pushed a commit that referenced this pull request Nov 10, 2025
@bkchr @github-actions
offchain-worker: Do not intialize the entire System again (#10235)
d71860f 
When calling `offchain-worker` we were initializing the entire `System`
again with the same block we are running on top of. However, with [the
change to require strictly increasing block
numbers](#10180) the
offchain-worker was failing. This is now solved by just registering the
missing digests. The rest of the changes done by `initialize` are not
important for offchain workers.

The pull request ensures that we are actually testing this behavior of
the offchain worker now.

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit 405e0bd)
bkchr added a commit that referenced this pull request Nov 11, 2025
@paritytech-release-backport-bot @bkchr
[stable2509] Backport #10180 (#10229)
3d933f0 
Backport #10180 into `stable2509` from bkchr.

See the
[documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md)
on how to use this bot.

<!--
  # To be used by other automation, do not modify:
  original-pr-number: #${pull_number}
-->

---------

Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <info@kchr.de>
@ipapandinas ipapandinas mentioned this pull request Dec 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skunert skunert skunert approved these changes

@bkontur bkontur bkontur approved these changes

@xermicus xermicus xermicus approved these changes

@sandreim sandreim sandreim approved these changes

+1 more reviewer

@nkpar nkpar nkpar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A4-backport-stable2506 Pull request must be backported to the stable2506 release branch A4-backport-stable2509 Pull request must be backported to the stable2509 release branch T1-FRAME This PR/Issue is related to core FRAME, the framework.

Projects

[preview] release tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@bkchr @pgherveou @0xRVE @nkpar @skunert @bkontur @xermicus @sandreim