fix: adjust e2e tests after uplift stable2506 #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dinonard
approved these changes
Dec 29, 2025
Comment on lines
+50
to
57
| // Set the current block number in storage to be exactly 1 less than target | ||
| // This satisfies the runtime's assertion: current_block + 1 == new_block | ||
| await astar.dev.setStorage({ | ||
| system: { | ||
| number: targetBlockHeight - 1, | ||
| }, | ||
| }) | ||
| await astar.dev.newBlock({ count: 1, unsafeBlockHeight: targetBlockHeight }) |
Contributor
There was a problem hiding this comment.
I'm surprised that .newBlock doesn't handle this update since it will fail otherwise (except if advancing to the next consecutive block).
Contributor
Author
There was a problem hiding this comment.
Me too, even when using the latest chopstick version. The new assert check in the frame system code is new (1month old) and the issue is happening when using unsafeBlockHeight so maybe it has not been patched yet? I will consider open an issue later to flag it.
Contributor
There was a problem hiding this comment.
newBlock doesn't handle it because there's no assertion, or at least there was not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust tests after:
stable2506uplift - chore: Update to PolkadotSDK releasestable2506Astar#1572BlockNumberis strictly increasing paritytech/polkadot-sdk#10180