Skip to content

Fix substring comparison for dependency detection #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joao-paulo-parity merged 1 commit into from
Apr 12, 2022
Merged

Fix substring comparison for dependency detection #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions check_dependent_project.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,12 @@ match_dependent_crates() {
source)
next="crate"

if [ "${line:0:${#our_crates_source}}" == "$our_crates_source" ]; then
if [[
# git+https://github.com/$org/$repo
"$line" == "$our_crates_source" ||
# git+https://github.com/$org/$repo?branch=master
"${line:0:$(( ${#our_crates_source} + 1 ))}" == "${our_crates_source}?"
]]; then
local found
for our_crate in "${our_crates[@]}"; do
if [ "$our_crate" == "$crate" ]; then
Expand Down Expand Up @@ -179,7 +184,12 @@ detect_dependencies_among_companions() {

for comp in "${companions[@]}"; do
local companion_crate_source="$org_crates_prefix/$comp"
if [ "${line:0:${#companion_crate_source}}" == "$companion_crate_source" ]; then
if [[
# git+https://github.com/$org/$repo
"$line" == "$companion_crate_source" ||
# git+https://github.com/$org/$repo?branch=master
"${line:0:$(( ${#companion_crate_source} + 1 ))}" == "${companion_crate_source}?"
]]; then
# prevent duplicates in dependencies_among_companions
local found
for dep_comp in "${dependencies_among_companions[@]}"; do
Expand Down