Bump secp256k1 to 0.19, use global context

[vorot93]

No description provided.

[dvdplm]

Needs cargo fmt run.

The test failure is actually relevant: all-zero messages are not invalid anymore. I think this is alright for ethereum but my memory is weak and I don't remember the details tbh.

Jumped the gun, sorry!

[niklasad1]

The test failure is actually relevant: all-zero messages are not invalid anymore. I think this is alright for ethereum but my memory is weak and I don't remember the details tbh.

rust-bitcoin/rust-secp256k1#207 is included in this release. I think you are right.

Do you remember the ethereum ecrecover builtin bug :)?

//cc @sorpaas I guess you know this ^^

[ordian]

yeah, I think we should remove the failing test and ZeroesAllowedMessage or do you have another suggestion? :)

[niklasad1]

yeah, I think we should remove the failing test and ZeroesAllowedMessage or do you have another suggestion? :)

I completely agree to remove the failing test.

[sorpaas]

@ordian @niklasad1 I'd propose we change this failing test to be "test zero message is valid".

I'll let the OpenEthereum people know about this just in case.

[dvdplm]

LGTM. Can you please add this to the CHANGELOG as a breaking change? :)

[vorot93]

@dvdplm done

[vorot93]

@dvdplm @ordian @sorpaas should be ready for merge