This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Fix ecrecover builtin#11623
Merged
Merged
Conversation
…h/parity-ethereum into dp/chore/upgrade-parity-crypto * 'dp/chore/upgrade-parity-crypto' of github.com:paritytech/parity-ethereum: ethash: use overlapping bytes after all ethash: sneaky spaces ethash: upgrade keccak-hash
…h/parity-ethereum into dp/chore/upgrade-parity-crypto * 'dp/chore/upgrade-parity-crypto' of github.com:paritytech/parity-ethereum: revert submodule update
* master: Fix Goerli syncing (#11604)
dvdplm
added
A3-inprogress ⏳
Collaborator
Author
|
@q9f This should be the second fix needed and it would be great if you could test this, thanks. |
Member
|
recompiling. |
niklasad1
reviewed
Apr 11, 2020
Collaborator
|
Goerli synced for on me this branch 💪 👍 |
niklasad1
approved these changes
Apr 11, 2020
Collaborator
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
LGTM, modulo the TODO
Member
|
* master: Upgrade parity-common deps to latest (#11620)
Collaborator
Author
|
I have synced goerli, kotti and half of rinkeby from genesis. Also warp synced eth. |
ordian
approved these changes
Apr 14, 2020
ordian
added
A8-looksgood 🦄
sorpaas
approved these changes
Apr 14, 2020
dvdplm
added a commit
that referenced
this pull request
Apr 14, 2020
* master: Fix ecrecover builtin (#11623)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
ecrecoverbuiltin in the presence of all-zero messages.Related to https://github.com/openethereum/openethereum/pull/11604