Implement codec for ethereum types#393
Merged
Merged
Conversation
Contributor
Author
|
This is not a breaking change so I believe a patch version bump might be enough. |
ordian
approved these changes
May 15, 2020
Contributor
ordian
left a comment
ordian
left a comment
There was a problem hiding this comment.
Looks good, would be nice to test this with --all-features in CI.
Contributor
|
Please update the changelogs as well. |
Contributor
|
|
Contributor
Author
|
@dvdplm It's this -- https://github.com/paritytech/frontier |
Contributor
Author
|
Published v0.9.2 for ethbloom and ethereum-types! |
ordian
added a commit
that referenced
this pull request
Jun 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds codec support for
ethbloomandethereum-types, which is needed in Frontier.