Skip to content

uint: manually implement Eq and Hash#390

Merged
ordian merged 7 commits into
masterfrom
ao-manually-implement-eq
May 18, 2020
Merged

uint: manually implement Eq and Hash#390
ordian merged 7 commits into
masterfrom
ao-manually-implement-eq

Conversation

@ordian
Copy link
Copy Markdown
Contributor

@ordian ordian commented May 12, 2020

Part of #388.
It doesn't allow U4096 yet, currently blocked on an issue with crunchy.

@ordian ordian force-pushed the ao-manually-implement-eq branch from 25b6790 to b4f1473 Compare May 12, 2020 10:56
LuoZijun
LuoZijun reviewed May 18, 2020
View reviewed changes
Comment thread uint/src/uint.rs Outdated
niklasad1
niklasad1 approved these changes May 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, perhaps add a test for construct_uint! with 33 elements, or is it blocked on crunchy?

@ordian
Copy link
Copy Markdown
Contributor Author

ordian commented May 18, 2020 •
edited
Loading

perhaps add a test for construct_uint! with 33 elements, or is it blocked on crunchy?

yep, even 32 elements are challenging the rustc compiler quite a bit

@ordian ordian merged commit 8e12159 into master May 18, 2020
@ordian ordian deleted the ao-manually-implement-eq branch May 18, 2020 11:05
ordian added a commit that referenced this pull request May 18, 2020
@ordian
Merge branch 'master' into ao-uint-wrapping-offset
194e923 
* master:
  uint: manually implement `Eq` and `Hash` (#390)
  uint: simplify `Ord` impl (#389)
  Implement codec for ethereum types (#393)
ordian added a commit that referenced this pull request Jun 12, 2020
@ordian
Merge branch 'master' into ao-type-metadata
5afa279 
* master:
  uint: manually implement `Eq` and `Hash` (#390)
  uint: simplify `Ord` impl (#389)
  Implement codec for ethereum types (#393)
  update changelogs and bump versions (#387)
  prepare new `kvdb-` release (#386)
@peilun-conflux peilun-conflux mentioned this pull request Aug 4, 2020
Closed
@ordian ordian mentioned this pull request Aug 8, 2020
Closed
ordian added a commit that referenced this pull request Aug 9, 2020
@ordian
uint: revert #390 partially
c4f7541
dvdplm pushed a commit that referenced this pull request Aug 25, 2020
@ordian
uint: make const matching work again (#421)
c36aead 
* uint: revert #390 partially

* uint: add a regression test

* uint: version bump

* tomorrow, maybe?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@LuoZijun LuoZijun LuoZijun left review comments

@dvdplm dvdplm dvdplm approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-pleasereview A2-insubstantial

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ordian @dvdplm @LuoZijun @niklasad1