You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the switch to depend on primitive-types a local dependency was used ({ path = "../primitive-types" }). And a new version was never published, which causes trouble for depending crates higher up the stack.
Bump to 0.2.0
Question: should the version be 0.2 here? I think so.
Using path = "../path/to/dep" to specify dependencies is not allowed when publishing crates, so that's one problem. Another problem is that if you use [patch] to load some crates from a git branch and some others a your local checkout and those two patched crates share a dependency, then you'll end up loading two different crates, which, even if they're exactly the same code can cause hard-to-debug issues.
I think the only time it's ok to use a path in parity-common is when the dependency is below, i.e. for sub-crates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the switch to depend onprimitive-typesa local dependency was used ({ path = "../primitive-types" }). And a new version was never published, which causes trouble for depending crates higher up the stack.Bump to 0.2.0
Question: should the version be0.2here? I think so.