Skip to content

Use raw balance value if tokenDecimals property is missing #1299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svyatonik merged 2 commits into from
Jan 31, 2022
Merged

Use raw balance value if tokenDecimals property is missing #1299

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
627045f
use raw balance value if tokenDecimals property is missing
svyatonik Jan 31, 2022
52fba2c
fmt
svyatonik Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions relays/lib-substrate-relay/src/messages_metrics.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,9 +202,20 @@ where
return Ok(metrics)
}

let token_decimals = client.token_decimals().await?.ok_or_else(|| {
SubstrateError::Custom(format!("Missing token decimals from {} system properties", C::NAME))
})?;
// if `tokenDecimals` is missing from system properties, we'll be using
let token_decimals = client
.token_decimals()
.await?
.map(|token_decimals| {
log::info!(target: "bridge", "Read `tokenDecimals` for {}: {}", C::NAME, token_decimals);
token_decimals
})
.unwrap_or_else(|| {
// turns out it is normal not to have this property - e.g. when polkadot binary is
// started using `polkadot-local` chain. Let's use minimal nominal here
log::info!(target: "bridge", "Using default (zero) `tokenDecimals` value for {}", C::NAME);
0
});
let token_decimals = u32::try_from(token_decimals).map_err(|e| {
anyhow::format_err!(
"Token decimals value ({}) of {} doesn't fit into u32: {:?}",
Expand Down