Use raw balance value if tokenDecimals property is missing#1299
Merged
Use raw balance value if tokenDecimals property is missing#1299
Conversation
svyatonik
added a commit
that referenced
this pull request
Feb 1, 2022
* Bump Substrate/Polkadot/Cumulus refs (#1295) Substrate: 31d90c202d6df9ce3837ee55587b604619a912ba Polkadot: 60df3c55c711c2872872d6220f98b2611340e051 Cumulus: a963055 * bump chain spec versions (#1297) * Fix ss58 prefixes of Polkadot, Kusama and Westend used by relay (#1298) * fix ss58 prefixes of Polkadot, Kusama and Westend * fmt * Use raw balance value if tokenDecimals property is missing (#1299) * use raw balance value if tokenDecimals property is missing * fmt * Revert nightly docker pin (#1301) * Revert "pin bridges-ci image (#1256)" This reverts commit 4009d97. * Revert "remporary use pinned bridges-ci image in Dockerfile (#1258)" This reverts commit 4f98840. * fix session length of Rococo and Wococo (#1304)
svyatonik
added a commit
that referenced
this pull request
Feb 1, 2022
* use raw balance value if tokenDecimals property is missing * fmt
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
…cation between binary and repo dir (#1299) * bringing back repo checkout and adding a temp dir to avoid name duplication between binary and repo dir * added hash to the action Co-authored-by: Chevdor <chevdor@users.noreply.github.com> * adjusted extrinsic ordering action * addressed comments from PR * addressed comments from PR * variables reoredering Co-authored-by: Chevdor <chevdor@users.noreply.github.com>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently the code introduced in #1291 is overreacting to errors. E.g. when running local Rococo/Wococo nodes,
tokenDecimalsproperty is missing from the chain properties. The solution is to use raw balance value in this case. On real chains we shall not see this.