Conversation
arkpar
approved these changes
Feb 20, 2020
zhangsoledad
added a commit
to zhangsoledad/ckb
that referenced
this pull request
Apr 2, 2020
Should be reverted once jsonrpc with paritytech/jsonrpc#543 is released
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be honest I'm not 100% sure that this is the right thing to do. Blocking on
dropdoes not sound like a good idea to me, but we do that already for WS server (and it seems desired for instance insubstrate), hence opted to implement for HTTP as well.