This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Wait for RPC server to cleanup on shutdown#5004
Merged
Merged
Conversation
arkpar
added
A0-please_review
Contributor
|
The WS server for sure does: I was sure that HTTP server does as well, but it seems not. Will make a PR upstream. |
bkchr
approved these changes
Feb 21, 2020
Member
Author
|
Should be reverted once jsonrpc with paritytech/jsonrpc#543 is released |
General-Beck
pushed a commit
to General-Beck/substrate
that referenced
this pull request
Mar 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RPC servers currently don't wait for worker threads to cleanup. This may result in RPC handlers, which contain a reference to the DB, to be still alive when the main thread terminates, leading to segfaults.
@tomusdrw perhaps
http::Servershould wait ondropinternally?