This repository was archived by the owner on Nov 11, 2022. It is now read-only.
sp-io update#289
Merged
Merged
Conversation
Author
adoerr
reviewed
Sep 9, 2021
Contributor
adoerr
left a comment
There was a problem hiding this comment.
@chevdor I'm a bit confused, why the sp-io update is needed at the BEEFY level.
Whenver I updated the BEEFY dep in Polkadot I first do a
cargo update -p beefy-primitves
and then a
cargo update -p sp-io --precise [exact commit needed for Polkadot]
This usaully gives the the minimal set of changes for Cargo.lock. What am I missing here 🤔
Author
|
The issue is that:
At the Polkadot level, running a Do you see any potential issue with this update ? |
adoerr
approved these changes
Sep 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR applies
cargo update sp-iointo thepolkadot-v0.9.10.The
polkadot-v0.9.10in Substrate saw some changes so we need to update accordingly.