Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

sp-io update#289

Merged
tomusdrw merged 1 commit into
polkadot-v0.9.10from
wk-0.9.10-sp_io-update
Sep 10, 2021
Merged

sp-io update#289
tomusdrw merged 1 commit into
polkadot-v0.9.10from
wk-0.9.10-sp_io-update

Conversation

@chevdor
Copy link
Copy Markdown

@chevdor chevdor commented Sep 9, 2021

This PR applies cargo update sp-io into the polkadot-v0.9.10.

The polkadot-v0.9.10 in Substrate saw some changes so we need to update accordingly.

@chevdor
Copy link
Copy Markdown
Author

chevdor commented Sep 9, 2021

@tomusdrw we will likely get in this PR the same CI failures as in #285 (I already see the deny issue). Do you want to handle those differently for this PR?

Copy link
Copy Markdown
Contributor

@adoerr adoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chevdor I'm a bit confused, why the sp-io update is needed at the BEEFY level.

Whenver I updated the BEEFY dep in Polkadot I first do a
cargo update -p beefy-primitves
and then a
cargo update -p sp-io --precise [exact commit needed for Polkadot]

This usaully gives the the minimal set of changes for Cargo.lock. What am I missing here 🤔

@chevdor
Copy link
Copy Markdown
Author

chevdor commented Sep 9, 2021

The issue is that:

  • beefy depends on Substrate
  • diener nicely switched all the deps to the new Substrate branch polkadot-v0.9.10
  • in the meantime, the branch evolved but the referenced commits did not

At the Polkadot level, running a cargo update -p sp-io gives me missmatches on some deps compared to cargo update -p beefy-primitives. With this PR, I am trying to align the two.

Do you see any potential issue with this update ?

@adoerr adoerr self-requested a review September 9, 2021 13:18
@tomusdrw tomusdrw merged commit 9954b61 into polkadot-v0.9.10 Sep 10, 2021
@tomusdrw tomusdrw deleted the wk-0.9.10-sp_io-update branch September 10, 2021 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants