Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

chore: update beefy to substrate branch polkadot-v0.9.10#285

Merged
adoerr merged 1 commit into
polkadot-v0.9.10from
wk-polkadot-v0.9.10
Sep 8, 2021
Merged

chore: update beefy to substrate branch polkadot-v0.9.10#285
adoerr merged 1 commit into
polkadot-v0.9.10from
wk-polkadot-v0.9.10

Conversation

@chevdor
Copy link
Copy Markdown

@chevdor chevdor commented Sep 6, 2021

This PR updates the substrate dependencies to the polkadot-v0.9.10 branch.

See below for details about the 2 CI checks that are failing.

@chevdor chevdor requested a review from s3krit September 6, 2021 09:59
@chevdor
Copy link
Copy Markdown
Author

chevdor commented Sep 7, 2021

The clippy issues can be silenced by using a slightly older nightly.

echo "nightly-2021-09-01" > rust-toolchain
rustup target add wasm32-unknown-unknown
cargo clippy --all-targets -- -D warnings

As long as nightly is not newer than 2021-09-01, the tests will pass.

@chevdor
Copy link
Copy Markdown
Author

chevdor commented Sep 7, 2021

The deny issue may require an additionnal PR in substrate though.

@tomusdrw
Copy link
Copy Markdown
Contributor

tomusdrw commented Sep 7, 2021

@chevdor please consider ignoring the advisory for now (deny.toml), we can report that as a separate issue and deal with it later.

@chevdor
Copy link
Copy Markdown
Author

chevdor commented Sep 7, 2021

@tomusdrw thanks for the hint. I will def. consider this option if my test does not end up well.
I am actually testing if we can integrate paritytech/substrate#9547 in the 0.9.10 release branch in substrate to address the problem.

@chevdor
Copy link
Copy Markdown
Author

chevdor commented Sep 7, 2021

ref. paritytech/substrate#9722

@chevdor
Copy link
Copy Markdown
Author

chevdor commented Sep 7, 2021

@tomusdrw I will do more than consider your option :) Merging paritytech/substrate#9547 is doable but it only partly solves the deny isssue.

@chevdor chevdor requested review from adoerr and tomusdrw September 7, 2021 15:38
@chevdor
Copy link
Copy Markdown
Author

chevdor commented Sep 8, 2021

Considering the thread above, this PR would be ready to merge.

@adoerr adoerr merged commit 2bd4ca6 into polkadot-v0.9.10 Sep 8, 2021
@adoerr adoerr deleted the wk-polkadot-v0.9.10 branch September 8, 2021 08:23
@tomusdrw
Copy link
Copy Markdown
Contributor

tomusdrw commented Sep 8, 2021

Ugh, oh, I was hoping we can keep the CI green and ignore the advisory in deny.toml file instead of merging with failing CI.

@adoerr
Copy link
Copy Markdown
Contributor

adoerr commented Sep 8, 2021

Sorry, my bad. Didn't want to block the Polkadot update any longer. Especially not since master is good and the CI issues are imo relatively minor.

@chevdor chevdor mentioned this pull request Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants