Skip to content

Replace hashmap_core with hashbrown #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andresilva merged 1 commit into from
Aug 20, 2019
Merged

Replace hashmap_core with hashbrown #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ log = "0.4"
parking_lot = { version = "0.9", optional = true }
parity-scale-codec = { version = "1.0.3", optional = true, default-features = false, features = ["derive"] }
num = { package = "num-traits", version = "0.2", default-features = false }
hashmap_core = { version = "0.1.10", default-features = false }
hashbrown = { version = "0.6" }
Copy link
Copy Markdown
Contributor

@andresilva andresilva Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to compile with default-features = false. finality-grandpa is no-std compatible.

Copy link
Copy Markdown
Contributor Author

@koushiro koushiro Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hashbrown supports no_std by default.

Copy link
Copy Markdown
Contributor

@andresilva andresilva Aug 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know that. Thanks :)


[dev-dependencies]
exit-future = "0.1.2"
Expand All @@ -22,6 +22,6 @@ tokio = "0.1.8"

[features]
default = ["std"]
std = ["parity-scale-codec/std", "hashmap_core/disable", "num/std", "parking_lot"]
std = ["parity-scale-codec/std", "num/std", "parking_lot"]
derive-codec = ["parity-scale-codec"]
test-helpers = []
2 changes: 1 addition & 1 deletion src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ use collections::Vec;
mod collections {
pub use alloc::collections::*;
pub use alloc::vec::Vec;
pub use hashmap_core::{map as hash_map, HashMap, HashSet};
pub use hashbrown::{hash_map, HashMap, HashSet};
}

#[cfg(feature = "std")]
Expand Down