Replace hashmap_core with hashbrown#84
Merged
andresilva merged 1 commit intoparitytech:masterfrom Aug 20, 2019
koushiro:replace-hashmap-core
Merged
Replace hashmap_core with hashbrown#84andresilva merged 1 commit intoparitytech:masterfrom koushiro:replace-hashmap-core
andresilva merged 1 commit intoparitytech:masterfrom
koushiro:replace-hashmap-core
Conversation
Signed-off-by: koushiro <koushiro.cqx@gmail.com>
|
It looks like @koushiro signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
=========================================
- Coverage 90.79% 88.19% -2.6%
=========================================
Files 10 10
Lines 3390 2491 -899
=========================================
- Hits 3078 2197 -881
+ Misses 312 294 -18
Continue to review full report at Codecov.
|
andresilva
suggested changes
Aug 20, 2019
| parity-scale-codec = { version = "1.0.3", optional = true, default-features = false, features = ["derive"] } | ||
| num = { package = "num-traits", version = "0.2", default-features = false } | ||
| hashmap_core = { version = "0.1.10", default-features = false } | ||
| hashbrown = { version = "0.6" } |
Contributor
There was a problem hiding this comment.
We need to compile with default-features = false. finality-grandpa is no-std compatible.
Contributor
Author
There was a problem hiding this comment.
hashbrown supports no_std by default.
Contributor
There was a problem hiding this comment.
Oh, I didn't know that. Thanks :)
andresilva
approved these changes
Aug 20, 2019
Contributor
|
Thanks for the PR @koushiro! :) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: koushiro koushiro.cqx@gmail.com
related issue: #83