This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Merged
Conversation
- Moved most of the logic into xcm-handler pallet - Altered the outgoing XCMP API from push to pull - Changed underlying outgoing queue data structures to avoid multi-page read/writes - Introduced queuing for incoming messages - Introduced signal messages as a flow-control sub-stream - Introduced flow-control with basic threshold back-pressure - Introduced overall weight limitation on messages executed - Additonal alterations to XCM APIs for the new system
gavofyork
commented
Apr 7, 2021
pallets/xcm-handler/src/lib.rs
Outdated
| } | ||
| _ => { | ||
| /* TODO: Handle other cases, like downward message */ | ||
| // Here is where we handle additional cases such as into parachains, bridges or |
4meta5
reviewed
Apr 11, 2021
Co-authored-by: Amar Singh <asinghchrony@protonmail.com>
bkchr
reviewed
Apr 13, 2021
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com>
Member
|
Some really specific logic in it. |
shawntabrizi
approved these changes
Apr 14, 2021
Member
shawntabrizi
left a comment
shawntabrizi
left a comment
There was a problem hiding this comment.
I think it should be fine to merge if there is a new issue opened to add tests particularly to the xcmp-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on paritytech/polkadot#2836
Tracked by paritytech/polkadot#2841
Also includes XCMP message dispatch system reimagining:
Also introduces the ping pallet for pinging between chains.