Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Comments

add try-runtime to ping pallet#2767

Merged
paritytech-processbot[bot] merged 4 commits intomasterfrom
bruno-try-runtime-cumulus-ping
Jun 23, 2023
Merged

add try-runtime to ping pallet#2767
paritytech-processbot[bot] merged 4 commits intomasterfrom
bruno-try-runtime-cumulus-ping

Conversation

@brunopgalvao
Copy link
Contributor

Fixes: #2704

@brunopgalvao brunopgalvao self-assigned this Jun 21, 2023
@brunopgalvao brunopgalvao added D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit B0-silent Changes should not be mentioned in any release notes labels Jun 21, 2023
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need this pallet at all…

@brunopgalvao
Copy link
Contributor Author

Not sure if we need this pallet at all…

Here is the original PR for the ping pallet (aka spambot): #391

Currently it is in the Trappist stout runtime:

That is why I need the try-runtime features for it.

I will let someone else comment if this pallet is still needed or not in Cumulus.

Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@brunopgalvao
Copy link
Contributor Author

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 4979c35

@brunopgalvao
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 3137e73 into master Jun 23, 2023
@paritytech-processbot paritytech-processbot bot deleted the bruno-try-runtime-cumulus-ping branch June 23, 2023 14:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

B0-silent Changes should not be mentioned in any release notes D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cumulus_ping does not have the try-runtime feature enabled

3 participants