This repository has been archived by the owner on Sep 14, 2023. It is now read-only.
chore: update scale dependency to 0.10.0 #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanleecode
force-pushed
the
chore/scale-0.10-update
branch
from
28545d9 to
4fe8996
Compare
ryanleecode
force-pushed
the
chore/scale-0.10-update
branch
from
4fe8996 to
0a0fbcb
Compare
tjjfvi
reviewed
Jan 10, 2023
tjjfvi
reviewed
Jan 10, 2023
tjjfvi
reviewed
Jan 10, 2023
tjjfvi
approved these changes
Jan 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #497.
One minor downside to this change is that the types can no longer "catch" the optional fields. i.e. if the field is optional and we don't put it in the codec then it wont be caught by the compiler.