Skip to content
This repository has been archived by the owner on Sep 14, 2023. It is now read-only.

upgrade scale to v0.10.0 #497

Closed
tjjfvi opened this issue Jan 6, 2023 · 0 comments · Fixed by #498
Closed

upgrade scale to v0.10.0 #497

tjjfvi opened this issue Jan 6, 2023 · 0 comments · Fixed by #498
Assignees

Comments

@tjjfvi
Copy link
Contributor

tjjfvi commented Jan 6, 2023

Breaking changes were introduced in tjjfvi/subshape#128; most notably:

 const foo = $.object(
-  ["bar", $.u8],
-  ["baz", $.str],
+  $.field("bar", $.u8),
+  $.field("baz", $.str),
 )

For now, for simplicity, I think we should use $.field("foo", $.option($bar)) instead of $.optionalField("foo", $bar) in the codegen. But in the non-generated code, I see no reason not to use $.optionalField.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants