Show training error msg #495
Conversation
|
This pull request fixes 1 alert when merging 64bc1f0 into 2e12b8d - view on LGTM.com fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
==========================================
+ Coverage 93.61% 93.65% +0.03%
==========================================
Files 99 99
Lines 8587 8633 +46
==========================================
+ Hits 8039 8085 +46
Misses 548 548
Continue to review full report at Codecov.
|
|
This pull request fixes 1 alert when merging 63544d3 into 2e12b8d - view on LGTM.com fixed alerts:
|
maikia
force-pushed
the
show_training_error_msg_cd
branch
from
63544d3 to
b3a4537
Compare
|
This pull request fixes 1 alert when merging 88d15bc into f7211c4 - view on LGTM.com fixed alerts:
|
|
@tomMoral could you also have a look at this one pls? |
| else: | ||
| self._logger.info( | ||
| f'Worker {worker} killed due to an error ' | ||
| f'during training: {stderr}' | ||
| ) | ||
| submission_status = 'training_error' | ||
| submission_status = 'training_error' |
There was a problem hiding this comment.
Ok so basically the issue was that all checking_error were set as training_error?
There was a problem hiding this comment.
no. that was actually another issue. The issue was that the error message was set to ''
|
thx @tomMoral |
* adding test and correcting the training error msg * update the tests * cleanup
closes #493
Adds a test checking if the training_error on aws is returned correctly (from the dispatcher perspective).
(I am not sure if it's not mocking overkill).
This should not be merged until #494 is.