enable AWS dispatcher tests #494
Conversation
… has assigned an instance before killing the worker
|
@rth I would be curious about your opinion on the config file. |
| sandbox_dir: starting_kit | ||
| submissions_dir: /tmp/databoard_test/submissions | ||
| predictions_dir: /tmp/databoard_test/preds | ||
| logs_dir: /tmp/databoard_test/log |
There was a problem hiding this comment.
maybe a bit dangerous that the system as /tmp folder?
There was a problem hiding this comment.
hm. I used the exactly the same directories for submissions, preds and log as it is already set for ramp_config_iris.yml (ie iris running on conda). boston_housing is also using /tmp folder. If you have alternative suggestion we should change it for all three
Codecov Report
@@ Coverage Diff @@
## master #494 +/- ##
==========================================
+ Coverage 93.61% 93.62% +0.01%
==========================================
Files 99 99
Lines 8552 8587 +35
==========================================
+ Hits 8006 8040 +34
- Misses 546 547 +1
Continue to review full report at Codecov.
|
|
@tomMoral would you mind having a look? thx |
| @@ -65,6 +65,7 @@ | |||
| from ramp_database.tools.submission import submit_starting_kits | |||
|
|
|||
| HERE = os.path.dirname(__file__) | |||
| ID_SUBMISSION = 7 | |||
There was a problem hiding this comment.
Is it supposed to be the same as the one in ramp-database/ramp_database/model/tests/test_submission.py?
If yes, maybe define it uniquely in ramp-database/ramp_database/testing.py
There was a problem hiding this comment.
could be... but I think it's easier to debug if you have the variable in the same testing file..
if it's very important to you I will change but I am slightly leaning against it.
There was a problem hiding this comment.
It is not that important. It is just that when you have constant, I find it better to not have multiple definitions. But if it is not critical (as it is in the tests), do what you think is the best :)
Co-authored-by: Thomas Moreau <[email protected]>
Co-authored-by: Thomas Moreau <[email protected]>
Co-authored-by: Thomas Moreau <[email protected]>
Co-authored-by: Thomas Moreau <[email protected]>
Co-authored-by: Thomas Moreau <[email protected]>
Co-authored-by: Thomas Moreau <[email protected]>
|
@tomMoral could you please merge if you are ok with the changes? |
* updated the way of setting the aws config template * init session toy db for aws * adding an event iris to run on aws for test db * sample test for not launching worker * catching correctly the wrong credentials error and checking if worker has assigned an instance before killing the worker * clean up * added aws config file for iris (tests) * cleanup * update the daemon test to account for new aws event * update the submission tests to work with the new event * clean up * update the tests * update the tests * spelling * Update ramp-database/ramp_database/model/tests/test_submission.py Co-authored-by: Thomas Moreau <[email protected]> * Update ramp-database/ramp_database/model/tests/test_submission.py Co-authored-by: Thomas Moreau <[email protected]> * Update ramp-database/ramp_database/model/tests/test_submission.py Co-authored-by: Thomas Moreau <[email protected]> * Update ramp-database/ramp_database/model/tests/test_submission.py Co-authored-by: Thomas Moreau <[email protected]> * Update ramp-database/ramp_database/model/tests/test_submission.py Co-authored-by: Thomas Moreau <[email protected]> * Update ramp-database/ramp_database/model/tests/test_submission.py Co-authored-by: Thomas Moreau <[email protected]> * Update ramp-database/ramp_database/model/tests/test_submission.py Co-authored-by: Thomas Moreau <[email protected]> * test if all the submissions are still in the new state * cleanup Co-authored-by: Thomas Moreau <[email protected]>
As for now the AWS worker is poorly tested.
This PR:
sorry for such a long PR. It was hard to cut it once it started to grow :-/